public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@thingy.jp>
To: visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com
Cc: u-boot@lists.denx.de, Daniel Palmer <daniel@thingy.jp>
Subject: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k
Date: Thu,  9 Apr 2026 07:09:25 +0900	[thread overview]
Message-ID: <20260408220928.3328551-3-daniel@thingy.jp> (raw)
In-Reply-To: <20260408220928.3328551-1-daniel@thingy.jp>

In Linux these are meant to read a little-endian value and swap
to the CPU endian.

In u-boot for m68k this is currently broken and prevents
virtio-mmio from functioning.

This change is only for classic m68k. Coldfire has read big-endian,
no swap for these in u-boot and Linux and existing drivers probably
depend on this.

Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
 arch/m68k/include/asm/io.h | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/arch/m68k/include/asm/io.h b/arch/m68k/include/asm/io.h
index 35ad4a1c0444..2577081d8363 100644
--- a/arch/m68k/include/asm/io.h
+++ b/arch/m68k/include/asm/io.h
@@ -23,18 +23,27 @@
 #define __raw_writew(w,addr) ((*(volatile u16 *) (addr)) = (w))
 #define __raw_writel(l,addr) ((*(volatile u32 *) (addr)) = (l))
 
-#define readb(addr)		in_8((volatile u8 *)(addr))
-#define writeb(b,addr)		out_8((volatile u8 *)(addr), (b))
-#if !defined(__BIG_ENDIAN)
-#define readw(addr)		(*(volatile u16 *) (addr))
-#define readl(addr)		(*(volatile u32 *) (addr))
-#define writew(b,addr)		((*(volatile u16 *) (addr)) = (b))
-#define writel(b,addr)		((*(volatile u32 *) (addr)) = (b))
+#define readb(addr)	in_8((volatile u8 *)(addr))
+#define writeb(b, addr)	out_8((volatile u8 *)(addr), (b))
+#ifdef CONFIG_M680x0
+/*
+ * For classic m68k these work the same way as Linux:
+ * Read a little endian value, swap to the CPU endian.
+ */
+#define readw(addr)	in_le16((volatile u16 *)(addr))
+#define readl(addr)	in_le32((volatile u32 *)(addr))
+#define writew(b, addr)	out_le16((volatile u16 *)(addr), (b))
+#define writel(b, addr)	out_le32((volatile u32 *)(addr), (b))
 #else
-#define readw(addr)		in_be16((volatile u16 *)(addr))
-#define readl(addr)		in_be32((volatile u32 *)(addr))
-#define writew(b,addr)		out_be16((volatile u16 *)(addr),(b))
-#define writel(b,addr)		out_be32((volatile u32 *)(addr),(b))
+/*
+ * For coldfire these read a big endian value and use it
+ * as-is. This means that for little endian devices on the
+ * bus like PCI device these won't work as expected currently.
+ */
+#define readw(addr)	in_be16((volatile u16 *)(addr))
+#define readl(addr)	in_be32((volatile u32 *)(addr))
+#define writew(b, addr)	out_be16((volatile u16 *)(addr), (b))
+#define writel(b, addr)	out_be32((volatile u32 *)(addr), (b))
 #endif
 
 /*
-- 
2.51.0


  parent reply	other threads:[~2026-04-08 22:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 22:09 [PATCH v3 0/5] Add virtio-mmio support to m68k virt machine Daniel Palmer
2026-04-08 22:09 ` [PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel() Daniel Palmer
2026-04-11 16:28   ` Simon Glass
2026-04-11 19:40   ` Angelo Dureghello
2026-04-08 22:09 ` Daniel Palmer [this message]
2026-04-11 16:28   ` [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k Simon Glass
2026-04-11 21:07   ` Angelo Dureghello
2026-04-12  0:59     ` Daniel Palmer
2026-04-08 22:09 ` [PATCH v3 3/5] virtio: mmio: Allow instantiation via platform data Daniel Palmer
2026-04-11 16:28   ` Simon Glass
2026-04-11 21:15   ` Angelo Dureghello
2026-04-12  5:12     ` Daniel Palmer
2026-04-08 22:09 ` [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a string Daniel Palmer
2026-04-11 20:30   ` Simon Glass
2026-04-08 22:09 ` [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances Daniel Palmer
2026-04-11 20:28   ` Angelo Dureghello
2026-04-12  6:42     ` Daniel Palmer
2026-04-11 20:31   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408220928.3328551-3-daniel@thingy.jp \
    --to=daniel@thingy.jp \
    --cc=angelo@kernel-space.org \
    --cc=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=visitorckw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox