Re: [PATCH] arm: mediatek: enable fw loader support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]

On Wed, Apr 15, 2026 at 02:27:39PM -0500, David Lechner wrote:
> On 4/15/26 10:02 AM, David Lechner wrote:
> > On 4/9/26 8:53 PM, Weijie Gao wrote:
> >> Enable SUPPORTS_FW_LOADER to allow the mediatek platform to use ethernet PHY
> >> drivers with fw loading.
> >>
> >> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> >> ---
> >>  arch/arm/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >> index 03416c55265..aee8e74dace 100644
> >> --- a/arch/arm/Kconfig
> >> +++ b/arch/arm/Kconfig
> >> @@ -868,6 +868,7 @@ config ARCH_MEDIATEK
> >>  	select SPL_LIBGENERIC_SUPPORT if SPL
> >>  	select SPL_OF_CONTROL if SPL
> >>  	select SUPPORT_SPL
> >> +	select SUPPORTS_FW_LOADER
> > 
> > I don't think this is how this config option is meant to be used.
> > 
> > Based on [1], it sounds like we just need to make sure CMDLINE and
> > ENV_SUPPORT are enabled in any config that also enables PHY_MEDIATEK_2P5GE.
> > 
> > I don't see any defconfig that enables PHY_MEDIATEK_2P5GE though, so
> > I'm not sure there is anything to do here. Unless it makes sense to
> > enable this in one of the existing defconfigs or add a new defconfig?
> > 
> > [1]: https://lore.kernel.org/u-boot/20260310162610.1163833-1-trini@konsulko.com/
> > 
> >>  	help
> >>  	  Support for the MediaTek SoCs family developed by MediaTek Inc.
> >>  	  Please refer to doc/README.mediatek for more information.
> > 
> 
> I thought about this some more and I wonder if we need to do something
> like this to make it actually work correctly though...
> 
> ---
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4e6a0c6a1b6..ed37daa28b8 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -73,6 +73,7 @@ config DYNAMIC_CRC_TABLE
>  
>  config SUPPORTS_FW_LOADER
>  	bool
> +	default y
>  	depends on CMDLINE
>  	depends on ENV_SUPPORT

That would be "def_bool y" in practice. And yes, that looks right, and
should have a Fixes.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]