From: Daniel Palmer <daniel@thingy.jp>
To: visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com
Cc: sjg@chromium.org, u-boot@lists.denx.de, Daniel Palmer <daniel@thingy.jp>
Subject: [PATCH v5 3/8] timer: goldfish: Use __raw_readl()
Date: Thu, 16 Apr 2026 18:39:22 +0900 [thread overview]
Message-ID: <20260416093927.602613-4-daniel@thingy.jp> (raw)
In-Reply-To: <20260416093927.602613-1-daniel@thingy.jp>
From: Kuan-Wei Chiu <visitorckw@gmail.com>
The Goldfish timer registers are native endian, so they act as
big-endian on the m68k virt machine. Currently, this driver uses
readl(), which works by luck because it's currently broken on m68k.
Use __raw_readl() instead to avoid breaking this driver when the
endianness of readl() is fixed.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Tested-by: Daniel Palmer <daniel@thingy.jp>
Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
drivers/timer/goldfish_timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/timer/goldfish_timer.c b/drivers/timer/goldfish_timer.c
index 70673bbd93c2..91277d7932ac 100644
--- a/drivers/timer/goldfish_timer.c
+++ b/drivers/timer/goldfish_timer.c
@@ -31,8 +31,8 @@ static u64 goldfish_timer_get_count(struct udevice *dev)
* We must read LOW before HIGH to latch the high 32-bit value
* and ensure a consistent 64-bit timestamp.
*/
- low = readl(priv->base + TIMER_TIME_LOW);
- high = readl(priv->base + TIMER_TIME_HIGH);
+ low = __raw_readl(priv->base + TIMER_TIME_LOW);
+ high = __raw_readl(priv->base + TIMER_TIME_HIGH);
time = ((u64)high << 32) | low;
--
2.51.0
next prev parent reply other threads:[~2026-04-16 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:39 [PATCH v5 0/8] Add virtio-mmio support to m68k virt machine Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 1/8] sysreset: qemu virt: Use __raw_writel() Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 2/8] rtc: goldfish: Use __raw_readl() and __raw_writel() Daniel Palmer
2026-04-16 9:39 ` Daniel Palmer [this message]
2026-04-16 9:39 ` [PATCH v5 4/8] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 5/8] virtio: mmio: Allow instantiation via platform data Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 6/8] virtio: cmd: Depend on VIRTIO_BLK Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 7/8] virtio: blk: Fix converting the vendor id to a string Daniel Palmer
2026-04-16 9:39 ` [PATCH v5 8/8] board: qemu: m68k: Create virtio mmio instances Daniel Palmer
2026-04-19 1:33 ` [PATCH v5 0/8] Add virtio-mmio support to m68k virt machine Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416093927.602613-4-daniel@thingy.jp \
--to=daniel@thingy.jp \
--cc=angelo@kernel-space.org \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox