Re: [PATCH v2 05/10] mach-snapdragon: add u-boot-spl-elf-sdm845.lds

Simon Glass
2026-04-12T13:01:00Z

Hi Michael,

On 2026-04-11T00:00:12, Michael Srba <michael.srba@seznam.cz> wrote:
> mach-snapdragon: add u-boot-spl-elf-sdm845.lds
>
> This custom linker script is required to produce a bootable ELF
> for the sdm845 SoC. An xbl_sec.elf must be provided, which will
> be put in a section in the ELF as required by the boot rom.
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
>
> arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)

> diff --git a/arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds b/arch/arm/mach-snapdragon/u-boot-spl-elf-sdm845.lds
> new file mode 100644
> @@ -0,0 +1,25 @@
> +TARGET("binary")

Please can you add an SPDX licence header? Other linker scripts like
arch/arm/cpu/armv8/u-boot-spl.lds have one.

> @@ -0,0 +1,25 @@
> + xbl_sec PT_LOAD FLAGS(5 | (0x5 << 24));

The FLAGS(5 | (0x5 << 24)) magic number could use a comment explaining
what the upper bits represent — presumably some Qualcomm-specific
segment flag?

> @@ -0,0 +1,25 @@
> + . = 0x0000000014699000;

This address appears specific to a particular XBL_SEC build (cf.
XBL_SEC_DONOR_SCM_ADDR in patch 7). Please can you add a comment
documenting where this comes from and whether it applies to all sdm845
devices?

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon