Re: [PATCH v2 06/10] mach-snapdragon: Kconfig: changes / additions to support SPL

Simon Glass
2026-04-12T13:01:10Z

Hi Michael,

On 2026-04-11T00:00:12, Michael Srba <michael.srba@seznam.cz> wrote:
> mach-snapdragon: Kconfig: changes / additions to support SPL
>
> An SoC to target has to be selected, e.g. SPL_TARGET_SDM845.
> This will select reasonable defaults and enable per-SoC linker
> script (if required).
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
>
> arch/arm/Kconfig | 31 +++++++++++++++++++++++++++-
> arch/arm/mach-snapdragon/Kconfig | 44 ++++++++++++++++++++++++++++++++++------
> 2 files changed, 68 insertions(+), 7 deletions(-)

> diff --git a/arch/arm/mach-snapdragon/Kconfig
> @@ -11,18 +11,12 @@ config SYS_VENDOR
> -config SYS_MALLOC_LEN
> - default 0x10000000

You are removing a duplicate SYS_MALLOC_LEN definition (0x10000000 vs
0x800000). Please can you split this fix into a separate preparatory
patch, since it is a bug fix unrelated to adding SPL support?

> diff --git a/arch/arm/mach-snapdragon/Kconfig
> +config SPL_TARGET_SDM845
> + bool "Set reasonable default values for running SPL in SRAM on sdm845 devices"

This is missing a help text. Please add one explaining what this
enables, perhaps referencing doc/board/qualcomm/spl.rst. Also, this
should probably have 'depends on SPL'

> diff --git a/arch/arm/Kconfig
> + select SPL_MMC if SPL

Just to check - is SPL_MMC really needed for all Snapdragon SPL
builds? The defconfig and documentation suggest only USB DFU is
currently supported. If MMC is not actually used yet, maybe use imply
rather than select

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon