Re: [PATCH v2 09/10] qualcomm: add defconfig, env and docs for SPL on sdm845

Simon Glass
2026-04-12T13:01:50Z

Hi Michael,

On 2026-04-11T00:00:12, Michael Srba <michael.srba@seznam.cz> wrote:
> qualcomm: add defconfig, env and docs for SPL on sdm845
>
> The defconfig should in principle be board-agnostic. Environment
> simply contains a dfu env specifying where to load u-boot proper
> (TEXT_BASE - 64).
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
>
> board/qualcomm/sdm845_spl.env | 2 +
> configs/sdm845_spl_defconfig | 131 ++++++++++++++++++++++++++++++++++++++++++
> doc/board/qualcomm/index.rst | 1 +
> doc/board/qualcomm/spl.rst | 87 ++++++++++++++++++++++++++++
> 4 files changed, 221 insertions(+)

> diff --git a/configs/sdm845_spl_defconfig b/configs/sdm845_spl_defconfig
> +CONFIG_SPL_TARGET_SDM845=y
> +CONFIG_SPL_MAX_SIZE=0x0

Setting SPL_MAX_SIZE to 0x0 disables size checking entirely. Is that intended?

> diff --git a/configs/sdm845_spl_defconfig b/configs/sdm845_spl_defconfig
> +CONFIG_SPL_BSS_MAX_SIZE=0x20000

This conflicts with the Kconfig default of 0x2000 for
SPL_TARGET_SDM845. If 0x20000 is intentional, please can you also
update the Kconfig default, since the comment there says 'leaves
0x1e000 for the stack in worst case' which would no longer be true.

> diff --git a/doc/board/qualcomm/spl.rst b/doc/board/qualcomm/spl.rst
> +If you're unable to find one, you can also use JTAG/SWD to break at the SMC
> +entry and use gdp to jump to the u-boot entry point in EL3.

gdb

> diff --git a/doc/board/qualcomm/spl.rst b/doc/board/qualcomm/spl.rst
> +`make CROSS_COMPILE=aarch64-suse-linux- O=.output DEVICE_TREE=qcom/sdm845-shift-axolotl sdm845_spl_defconfig
> +
> +Then compile u-boot and specify the dts for your board

Please can you use :: and indented code blocks for commands, matching
the style in board.rst and dragonboard410c.rst.

Regards,
Simon