Re: [PATCH v2 08/10] mach-snapdragon: add board-spl.c and split out common code

Simon Glass
2026-04-12T13:01:40Z

Hi Michael,

On 2026-04-11T00:00:12, Michael Srba <michael.srba@seznam.cz> wrote:
> mach-snapdragon: add board-spl.c and split out common code
>
> Code in board.c will now only be compiled into U-Boot proper,
> and the new board_spl.c will only be built into SPL.
> Code in board_common.c is common to both phases.
>
> Also split out mem_map.c, which is currently common to both
> phases since it seems to not cause issues in SPL. In the future
> it should probably behave differenly in SPL, especially if dram
> initialization is supported.
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
>
> arch/arm/mach-snapdragon/Makefile | 8 +
> arch/arm/mach-snapdragon/board.c | 358 +-------------------------------
> arch/arm/mach-snapdragon/board_common.c | 56 +++++
> arch/arm/mach-snapdragon/board_spl.c | 35 ++++
> arch/arm/mach-snapdragon/mem_map.c | 318 ++++++++++++++++++++++++++++
> arch/arm/mach-snapdragon/qcom-priv.h | 4 +-
> 6 files changed, 429 insertions(+), 350 deletions(-)

The commit subject says board-spl.c but should say board_spl.c

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon