Re: [PATCH v2 07/10] mach-snapdragon: boot0.h: add sdm845_spl_boot0.h

Simon Glass
2026-04-17T12:47:18Z

Hi Michael,

On Fri, 17 Apr 2026 at 07:15, Michael Srba <Michael.Srba@seznam.cz> wrote:
>
> Hi,
>
> On 4/11/26 17:40, Simon Glass wrote:
> > Hi Michael,
> >
> > On 2026-04-11T00:00:12, Michael Srba <michael.srba@seznam.cz> wrote:
> >> mach-snapdragon: boot0.h: add sdm845_spl_boot0.h
> >>
> >> On sdm845, running u-boot SPL in EL3 requires escalting by using
> >> an unintentional feature in old builds of xbl_sec.elf. We do this
> >> in boot0.h so the rest of U-Boot can stay blissfully unaware
> >> of XBL_SEC. If we are already in EL3 for whatever reason, the
> >> code is skipped.
> >>
> >> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> >>
> >> arch/arm/mach-snapdragon/include/mach/boot0.h | 4 +
> >> .../include/mach/sdm845_spl_boot0.h | 120 +++++++++++++++++++++
> >> 2 files changed, 124 insertions(+)
> >> diff --git a/arch/arm/mach-snapdragon/include/mach/sdm845_spl_boot0.h b/arch/arm/mach-snapdragon/include/mach/sdm845_spl_boot0.h
> >> @@ -0,0 +1,120 @@
> >> +.macro movl Wn, imm
> >> + movz \Xn, \imm & 0xFFFF
> >> + movk \Xn, (\imm >> 16) & 0xFFFF, lsl 16
> >> +.endm
> > The macro parameter is named Wn but the body references \Xn - does
> > this actually build?
> I'm not sure why it displays like that for you, both for me locally and on
> https://lore.kernel.org/all/20260411-qcom_spl-v2-7-9609557cf562@seznam.cz/
> it displays correctly...

Yes I see it, thanks.

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon