Re: [PATCH 2/2] arm: axiado: Add AX3005 based SCM3005 board support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

On Tue, Apr 28, 2026 at 07:32:37PM -0700, Karthikeyan Mitran wrote:

> From: Siu Ming Tong <smtong@axiado.com>
> 
> Add U-Boot board support for the Axiado AX3005 based targets, a quad-core
> ARM Cortex-A53 (ARMv8) platform.
> 
> Board Kconfig introduces ARCH_AX3005, which selects ARM64, driver
> model, GIC-v3, and Zynq UART. TARGET_SCM3005 selects ARCH_AX3005,
> allowing future SoC variants to share the platform configuration.
> 
> Secondary cores use spin-table boot. ft_board_setup() corrects
> the cpu-release-addr in the FDT, which arch_fixup_fdt() overwrites
> with the post-relocation address. The board linker script pins
> spin_table_v8.o at offset 0x2fa0 from text base to match the
> address declared in the device tree.
> 
> Tested-by: Siu Ming Tong <smtong@axiado.com>
> Signed-off-by: Siu Ming Tong <smtong@axiado.com>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> Signed-off-by: Karthikeyan Mitran <kmitran@axiado.com>
> ---
>  MAINTAINERS                      |  10 +++
>  arch/arm/Kconfig                 |  17 ++++
>  board/axiado/scm3005/Kconfig     |  15 ++++
>  board/axiado/scm3005/Makefile    |   5 ++
>  board/axiado/scm3005/scm3005.c   | 128 +++++++++++++++++++++++++++
>  board/axiado/scm3005/u-boot.lds  | 183 +++++++++++++++++++++++++++++++++++++++
>  configs/ax3005_scm3005_defconfig |  73 ++++++++++++++++
>  include/configs/ax3005-scm3005.h |  29 +++++++
>  8 files changed, 460 insertions(+)

We're adding a new ARCH symbol, but without a new mach- directory, which
I suspect some of the board code should be in, instead. Also:

> diff --git a/board/axiado/scm3005/u-boot.lds b/board/axiado/scm3005/u-boot.lds
> new file mode 100644
> index 00000000000..8e56535fdf9
> --- /dev/null
> +++ b/board/axiado/scm3005/u-boot.lds
> @@ -0,0 +1,183 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright (c) 2021-2026 Axiado Corporation (or its affiliates).
> + *
> + * Based on arch/arm/cpu/armv8/u-boot.lds
> + */

What differs here really? Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]