Re: [PATCH v2 5/5] mtd: nand: raw: sunxi_spl: remove user data length reset

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 27 Mar 2026 15:05:08 +0100
Richard Genoud <richard.genoud@bootlin.com> wrote:

> No need to reset user data length registers in SPL.
> 
> In SPL, only the first user data length register is used, so we don't
> need to reset all of them.
> 
> Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>

Acked-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  drivers/mtd/nand/raw/sunxi_nand_spl.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/sunxi_nand_spl.c b/drivers/mtd/nand/raw/sunxi_nand_spl.c
> index 784ffb00cf70..cf351de4e8de 100644
> --- a/drivers/mtd/nand/raw/sunxi_nand_spl.c
> +++ b/drivers/mtd/nand/raw/sunxi_nand_spl.c
> @@ -224,22 +224,6 @@ static int nand_change_column(u16 column)
>  	return 0;
>  }
>  
> -/*
> - * On H6/H616 the user_data length has to be set in specific registers
> - * before writing.
> - */
> -static void sunxi_nfc_reset_user_data_len(const struct nfc_config *nfc)
> -{
> -	int loop_step = NFC_REG_USER_DATA_LEN_CAPACITY;
> -
> -	/* not all SoCs have this register */
> -	if (!NFC_REG_USER_DATA_LEN(nfc, 0))
> -		return;
> -
> -	for (int i = 0; i < nfc->caps->max_ecc_steps; i += loop_step)
> -		writel_nfc(0, NFC_REG_USER_DATA_LEN(nfc, i));
> -}
> -
>  static void sunxi_nfc_set_user_data_len(const struct nfc_config *nfc,
>  					int len, int step)
>  {
> @@ -355,7 +339,6 @@ static int nand_read_page(const struct nfc_config *conf, u32 offs,
>  		 */
>  		nand_change_column(oob_off);
>  
> -		sunxi_nfc_reset_user_data_len(conf);
>  		sunxi_nfc_set_user_data_len(conf, user_data_sz, nfc_step);
>  
>  		nand_exec_cmd(NFC_DATA_TRANS | NFC_ECC_OP);