U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <foss+uboot@0leil.net>
To: Casey Connolly <casey.connolly@linaro.org>,
	 Sumit Garg <sumit.garg@oss.qualcomm.com>,
	 Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
	 u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Bin Meng <bmeng.cn@gmail.com>
Cc: Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>
Subject: [PATCH v2 1/3] cmd: boot: fix edl being shown when not supported
Date: Thu, 07 May 2026 17:04:05 +0200	[thread overview]
Message-ID: <20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de> (raw)
In-Reply-To: <20260507-doc-sysreset-qcom-v2-0-37fef7a9cf92@cherry.de>

From: Quentin Schulz <quentin.schulz@cherry.de>

edl is implemented in the sysreset_ops.request_arg callback of the
qcom-psci sysreset driver. That callback is only called from
sysreset_request_arg() which is compiled only when
CONFIG_SYSRESET_CMD_RESET_ARGS=y.

Therefore, only show the edl option if that symbol is enabled.

It is in a separate if block because any option but -w will only be
handled when CONFIG_SYSRESET_CMD_RESET_ARGS=y as seen with the
implementation in do_reset() in drivers/sysreset/sysreset-uclass.c.

Fixes: ef06c5d76ff4 ("cmd: boot: Add '-edl' option to reset command documentation")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 cmd/boot.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cmd/boot.c b/cmd/boot.c
index d80f9d8c05d..29cdf4a9a81 100644
--- a/cmd/boot.c
+++ b/cmd/boot.c
@@ -60,8 +60,11 @@ U_BOOT_CMD(
 	reset, 2, 0,	do_reset,
 	"Perform RESET of the CPU",
 	"- cold boot without level specifier\n"
+#if IS_ENABLED(CONFIG_SYSRESET_CMD_RESET_ARGS)
+// All options handled by sysreset drivers via their sysreset_ops.request_arg callback
 #ifdef CONFIG_SYSRESET_QCOM_PSCI
 	"reset -edl - Boot to Emergency DownLoad mode\n"
+#endif
 #endif
 	"reset -w - warm reset if implemented"
 );

-- 
2.54.0


  reply	other threads:[~2026-05-07 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 15:04 [PATCH v2 0/3] cmd: reset: fixes related to Qualcomm's edl Quentin Schulz
2026-05-07 15:04 ` Quentin Schulz [this message]
2026-05-08 16:33   ` [PATCH v2 1/3] cmd: boot: fix edl being shown when not supported Simon Glass
2026-05-08 16:48     ` Quentin Schulz
2026-05-07 15:04 ` [PATCH v2 2/3] doc: usage: cmd: reset: fix typo Quentin Schulz
2026-05-08 16:33   ` Simon Glass
2026-05-07 15:04 ` [PATCH v2 3/3] doc: usage: cmd: reset: specify when the -edl option is available Quentin Schulz
2026-05-11 17:01   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de \
    --to=foss+uboot@0leil.net \
    --cc=bmeng.cn@gmail.com \
    --cc=casey.connolly@linaro.org \
    --cc=quentin.schulz@cherry.de \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=varadarajan.narayanan@oss.qualcomm.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox