Re: [PATCH 6/6] board: variscite: add support for the omap4_var_som

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]

On Tue, May 19, 2026 at 08:45:43AM +0200, Bastien Curutchet wrote:

> OMAP4 support is present but there isn't any board using it.
> 
> Add minimal support for the Variscite OMAP4-SoM (debug console + boot
> from SD card).
> Use the ti/omap/omap4-var-stk-om44 device-tree from the Linux kernel. The
> real representation of the SoM's hardware is located in
> ti/omap/omap4-var-som-om44.dtsi included in it.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
[snip]
> diff --git a/board/variscite/omap4_var_som/MAINTAINERS b/board/variscite/omap4_var_som/MAINTAINERS
> new file mode 100644
> index 00000000000..802059ea521
> --- /dev/null
> +++ b/board/variscite/omap4_var_som/MAINTAINERS
> @@ -0,0 +1,6 @@
> +ARM OMAP4 VARISCITE VAR-SOM-OM44 MODULE
> +M:	Bastien Curutchet <bastien.curutchet@bootlin.com>
> +S:	Maintained
> +F:	board/variscite/omap4_var_som
> +F:	include/configs/omap4_var_som.h
> +F:	configs/omap4_var_som_defconfig

So this could all be caught with:
N: omap4_var_som

Which is my way of moving to the next topic, omap4 needs a maintainer
too, if we're bringing it back.

[snip]
> diff --git a/include/configs/omap4_var_som.h b/include/configs/omap4_var_som.h
> new file mode 100644
> index 00000000000..fa916cc71d2
> --- /dev/null
> +++ b/include/configs/omap4_var_som.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * (C) Copyright 2010
> + * Texas Instruments Incorporated.
> + * Steve Sakoman  <steve@sakoman.com>

This part isn't right, is it?

> + * Configuration settings for the TI OMAP4 Variscite SOM board.
> + * See ti_omap4_common.h for OMAP4 common part
> + */
> +
> +#ifndef __CONFIG_VAR_SOM_H
> +#define __CONFIG_VAR_SOM_H
> +
> +#include <configs/ti_omap4_common.h>

Can we just set SYS_CONFIG_NAME or so to ti_omap4_common  and drop this
file? Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]