From: Tom Rini <trini@konsulko.com>
To: Aristo Chen <aristo.chen@canonical.com>
Cc: u-boot@lists.denx.de, Richard Weinberger <richard@nod.at>,
Adriana Nicolae <adriana@arista.com>,
Sam Protsenko <semen.protsenko@linaro.org>
Subject: Re: [PATCH v1 3/3] fdt_support: prefer __func__ over __FUNCTION__
Date: Mon, 25 May 2026 08:43:31 -0600 [thread overview]
Message-ID: <20260525144331.GL1858239@bill-the-cat> (raw)
In-Reply-To: <20260525132628.755148-4-aristo.chen@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Mon, May 25, 2026 at 01:26:25PM +0000, Aristo Chen wrote:
> A handful of printf call sites in fdt_fixup_memory_banks,
> __of_translate_address and fdt_get_dma_range still use the
> gcc-specific __FUNCTION__ identifier. checkpatch.pl prefers the
> C99-standard __func__ for new code, and the rest of this file already
> uses __func__, so convert the remaining occurrences for consistency.
>
> While in __of_translate_address, also re-align the continuation line
> of the inner Bad cell count printf so the second argument lines up
> with the open parenthesis of its printf instead of being one column
> off, silencing the alignment check that scripts/checkpatch.pl reports
> on the cleanup hunk. No behavioural change.
>
> Signed-off-by: Aristo Chen <aristo.chen@canonical.com>
Oh wow, I didn't realize we still had __FUNCTION__ anywhere in the code.
Can you please move this to it's own series and do a global fixup of
__FUNCTION__ -> __func__ ? Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-05-25 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 13:26 [PATCH v1 0/3] fdt_support: validate property lengths in chosen and dma-range fixups Aristo Chen
2026-05-25 13:26 ` [PATCH v1 1/3] fdt_support: bound serialN alias length before copying to stack Aristo Chen
2026-05-25 13:26 ` [PATCH v1 2/3] fdt_support: validate dma-ranges length in fdt_get_dma_range Aristo Chen
2026-05-25 13:26 ` [PATCH v1 3/3] fdt_support: prefer __func__ over __FUNCTION__ Aristo Chen
2026-05-25 14:43 ` Tom Rini [this message]
2026-05-25 14:48 ` [PATCH v1 0/3] fdt_support: validate property lengths in chosen and dma-range fixups Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525144331.GL1858239@bill-the-cat \
--to=trini@konsulko.com \
--cc=adriana@arista.com \
--cc=aristo.chen@canonical.com \
--cc=richard@nod.at \
--cc=semen.protsenko@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox