U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Md Shofiqul Islam <shofiqtest@gmail.com>
To: u-boot@lists.denx.de
Cc: ian.ray@gehealthcare.com, HuanWang@gehealthcare.com,
	brian.ruley@gehealthcare.com, martyn.welch@collabora.com,
	hs@nabladev.com, lukma@denx.de, sbabic@nabladev.com,
	festevam@gmail.com, Md Shofiqul Islam <shofiqtest@gmail.com>
Subject: [PATCH v2 2/2] imx6: clock: fix clk0/clk1 swap in select_ldb_di_clock_source()
Date: Tue, 30 Jun 2026 15:39:51 +0300	[thread overview]
Message-ID: <20260630123951.13385-3-shofiqtest@gmail.com> (raw)
In-Reply-To: <20260630123951.13385-1-shofiqtest@gmail.com>

clk0 was being written to LDB_DI1_CLK_SEL and clk1 to LDB_DI0_CLK_SEL.
The arguments were silently effective before because all callers passed
the same value for both, but the mapping was reversed.

Fixes: bd3e19dbd901 ("imx6: clock: allow different clock sources for ldb")
Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
---
 arch/arm/mach-imx/mx6/clock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/mx6/clock.c b/arch/arm/mach-imx/mx6/clock.c
index 828a101ba05..646d1fff6d7 100644
--- a/arch/arm/mach-imx/mx6/clock.c
+++ b/arch/arm/mach-imx/mx6/clock.c
@@ -1525,8 +1525,8 @@ void select_ldb_di_clock_source(enum ldb_di_clock clk0, enum ldb_di_clock clk1)
 	reg = readl(&mxc_ccm->cs2cdr);
 	reg &= ~(MXC_CCM_CS2CDR_LDB_DI1_CLK_SEL_MASK
 	      | MXC_CCM_CS2CDR_LDB_DI0_CLK_SEL_MASK);
-	reg |= ((clk0 << MXC_CCM_CS2CDR_LDB_DI1_CLK_SEL_OFFSET)
-	      | (clk1 << MXC_CCM_CS2CDR_LDB_DI0_CLK_SEL_OFFSET));
+	reg |= ((clk1 << MXC_CCM_CS2CDR_LDB_DI1_CLK_SEL_OFFSET)
+	      | (clk0 << MXC_CCM_CS2CDR_LDB_DI0_CLK_SEL_OFFSET));
 	writel(reg, &mxc_ccm->cs2cdr);
 
 	/* Unbypass pll3_sw_clk */
-- 
2.51.1


      parent reply	other threads:[~2026-06-30 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 12:39 [PATCH v2 0/2] imx6: fix LDB clock guard and clk0/clk1 swap Md Shofiqul Islam
2026-06-30 12:39 ` [PATCH v2 1/2] clk: imx6q: guard LDB clock init with appropriate video config Md Shofiqul Islam
2026-06-30 12:39 ` Md Shofiqul Islam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630123951.13385-3-shofiqtest@gmail.com \
    --to=shofiqtest@gmail.com \
    --cc=HuanWang@gehealthcare.com \
    --cc=brian.ruley@gehealthcare.com \
    --cc=festevam@gmail.com \
    --cc=hs@nabladev.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=lukma@denx.de \
    --cc=martyn.welch@collabora.com \
    --cc=sbabic@nabladev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox