From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Cc: Fabio Estevam <festevam@nabladev.com>,
Jonas Karlman <jonas@kwiboo.se>,
Ye Zhang <ye.zhang@rock-chips.com>,
Simon Glass <sjg@chromium.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Tom Rini <trini@konsulko.com>, huang lin <hl@rock-chips.com>
Subject: [PATCH v3 02/15] pinctrl: rockchip: Add RV1103B support
Date: Tue, 7 Jul 2026 09:31:00 -0600 [thread overview]
Message-ID: <20260707153135.2048115-3-sjg@chromium.org> (raw)
In-Reply-To: <20260707153135.2048115-1-sjg@chromium.org>
From: Ye Zhang <ye.zhang@rock-chips.com>
Add the pinctrl driver for the RV1103B.
Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
Signed-off-by: Fabio Estevam <festevam@nabladev.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Use regmap_update_bits() in all the remaining places (Jonas)
- Align continuation lines with the open parenthesis (checkpatch)
Changes in v2:
- Use the original author from Rockchip's vendor U-Boot tree
- Use regmap_update_bits()
- Remove unneeded blank lines
- Remove unneeded logging functions
drivers/pinctrl/rockchip/Makefile | 1 +
drivers/pinctrl/rockchip/pinctrl-rv1103b.c | 402 +++++++++++++++++++++
2 files changed, 403 insertions(+)
create mode 100644 drivers/pinctrl/rockchip/pinctrl-rv1103b.c
diff --git a/drivers/pinctrl/rockchip/Makefile b/drivers/pinctrl/rockchip/Makefile
index 0405df128df..b7ce6402ea3 100644
--- a/drivers/pinctrl/rockchip/Makefile
+++ b/drivers/pinctrl/rockchip/Makefile
@@ -19,5 +19,6 @@ obj-$(CONFIG_ROCKCHIP_RK3528) += pinctrl-rk3528.o
obj-$(CONFIG_ROCKCHIP_RK3568) += pinctrl-rk3568.o
obj-$(CONFIG_ROCKCHIP_RK3576) += pinctrl-rk3576.o
obj-$(CONFIG_ROCKCHIP_RK3588) += pinctrl-rk3588.o
+obj-$(CONFIG_ROCKCHIP_RV1103B) += pinctrl-rv1103b.o
obj-$(CONFIG_ROCKCHIP_RV1108) += pinctrl-rv1108.o
obj-$(CONFIG_ROCKCHIP_RV1126) += pinctrl-rv1126.o
diff --git a/drivers/pinctrl/rockchip/pinctrl-rv1103b.c b/drivers/pinctrl/rockchip/pinctrl-rv1103b.c
new file mode 100644
index 00000000000..4bd74312c8c
--- /dev/null
+++ b/drivers/pinctrl/rockchip/pinctrl-rv1103b.c
@@ -0,0 +1,402 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2024 Rockchip Electronics Co., Ltd
+ */
+
+#include <dm.h>
+#include <log.h>
+#include <dm/pinctrl.h>
+#include <regmap.h>
+#include <syscon.h>
+#include <linux/bitops.h>
+
+#include "pinctrl-rockchip.h"
+
+static int rv1103b_set_mux(struct rockchip_pin_bank *bank, int pin, int mux)
+{
+ struct rockchip_pinctrl_priv *priv = bank->priv;
+ int iomux_num = (pin / 8);
+ struct regmap *regmap;
+ u32 data, rmask;
+ int reg, mask;
+ u8 bit;
+
+ if (bank->bank_num == 2 && pin >= 12)
+ return 0;
+
+ regmap = priv->regmap_base;
+ reg = bank->iomux[iomux_num].offset;
+ if ((pin % 8) >= 4)
+ reg += 0x4;
+ bit = (pin % 4) * 4;
+ mask = 0xf;
+
+ if (bank->recalced_mask & BIT(pin))
+ rockchip_get_recalced_mux(bank, pin, ®, &bit, &mask);
+ data = (mask << (bit + 16));
+ rmask = data | (data >> 16);
+ data |= (mux & mask) << bit;
+
+ return regmap_update_bits(regmap, reg, rmask, data);
+}
+
+#define RV1103_DRV_BITS_PER_PIN 8
+#define RV1103_DRV_PINS_PER_REG 2
+#define RV1103_DRV_GPIO0_A_OFFSET 0x40100
+#define RV1103_DRV_GPIO0_B_OFFSET 0x50110
+#define RV1103_DRV_GPIO1_A01_OFFSET 0x140
+#define RV1103_DRV_GPIO1_A67_OFFSET 0x1014C
+#define RV1103_DRV_GPIO2_OFFSET 0x30180
+#define RV1103_DRV_GPIO2_SARADC_OFFSET 0x3080C
+
+static int rv1103b_calc_drv_reg_and_bit(struct rockchip_pin_bank *bank,
+ int pin_num, struct regmap **regmap,
+ int *reg, u8 *bit)
+{
+ struct rockchip_pinctrl_priv *priv = bank->priv;
+ int ret = 0;
+
+ *regmap = priv->regmap_base;
+ switch (bank->bank_num) {
+ case 0:
+ if (pin_num < 7)
+ *reg = RV1103_DRV_GPIO0_A_OFFSET;
+ else if (pin_num > 7 && pin_num < 14)
+ *reg = RV1103_DRV_GPIO0_B_OFFSET - 0x10;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 1:
+ if (pin_num < 6)
+ *reg = RV1103_DRV_GPIO1_A01_OFFSET;
+ else if (pin_num >= 6 && pin_num < 23)
+ *reg = RV1103_DRV_GPIO1_A67_OFFSET - 0xc;
+ else if (pin_num >= 24 && pin_num < 30)
+ *reg = RV1103_DRV_GPIO1_A67_OFFSET - 0xc;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 2:
+ if (pin_num < 12) {
+ *reg = RV1103_DRV_GPIO2_OFFSET;
+ } else if (pin_num >= 16) {
+ ret = -EINVAL;
+ } else {
+ *reg = RV1103_DRV_GPIO2_SARADC_OFFSET;
+ *bit = 10;
+
+ return 0;
+ }
+ break;
+
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ if (ret) {
+ printf("unsupported bank_num %d pin_num %d\n", bank->bank_num, pin_num);
+ return ret;
+ }
+
+ *reg += ((pin_num / RV1103_DRV_PINS_PER_REG) * 4);
+ *bit = pin_num % RV1103_DRV_PINS_PER_REG;
+ *bit *= RV1103_DRV_BITS_PER_PIN;
+
+ return 0;
+}
+
+static int rv1103b_set_drive(struct rockchip_pin_bank *bank,
+ int pin_num, int strength)
+{
+ struct regmap *regmap;
+ int reg, ret, i;
+ u32 data, rmask;
+ u8 bit;
+ int rmask_bits = RV1103_DRV_BITS_PER_PIN;
+
+ ret = rv1103b_calc_drv_reg_and_bit(bank, pin_num, ®map, ®, &bit);
+ if (ret)
+ return ret;
+
+ for (i = 0, ret = 1; i < strength; i++)
+ ret = (ret << 1) | 1;
+
+ if (bank->bank_num == 2 && pin_num >= 12) {
+ rmask_bits = 2;
+ ret = strength;
+ }
+
+ /* Enable the write to the equivalent lower bits */
+ data = ((1 << rmask_bits) - 1) << (bit + 16);
+ rmask = data | (data >> 16);
+ data |= (ret << bit);
+
+ return regmap_update_bits(regmap, reg, rmask, data);
+}
+
+#define RV1103_PULL_BITS_PER_PIN 2
+#define RV1103_PULL_PINS_PER_REG 8
+#define RV1103_PULL_GPIO0_A_OFFSET 0x40200
+#define RV1103_PULL_GPIO0_B_OFFSET 0x50204
+#define RV1103_PULL_GPIO1_A01_OFFSET 0x210
+#define RV1103_PULL_GPIO1_A67_OFFSET 0x10210
+#define RV1103_PULL_GPIO2_OFFSET 0x30220
+#define RV1103_PULL_GPIO2_SARADC_OFFSET 0x3080C
+
+static int rv1103b_calc_pull_reg_and_bit(struct rockchip_pin_bank *bank,
+ int pin_num, struct regmap **regmap,
+ int *reg, u8 *bit)
+{
+ struct rockchip_pinctrl_priv *priv = bank->priv;
+ int ret = 0;
+
+ *regmap = priv->regmap_base;
+ switch (bank->bank_num) {
+ case 0:
+ if (pin_num < 7)
+ *reg = RV1103_PULL_GPIO0_A_OFFSET;
+ else if (pin_num > 7 && pin_num < 14)
+ *reg = RV1103_PULL_GPIO0_B_OFFSET - 0x4;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 1:
+ if (pin_num < 6)
+ *reg = RV1103_PULL_GPIO1_A01_OFFSET;
+ else if (pin_num >= 6 && pin_num < 23)
+ *reg = RV1103_PULL_GPIO1_A67_OFFSET;
+ else if (pin_num >= 24 && pin_num < 30)
+ *reg = RV1103_PULL_GPIO1_A67_OFFSET;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 2:
+ if (pin_num < 12) {
+ *reg = RV1103_PULL_GPIO2_OFFSET;
+ } else if (pin_num >= 16) {
+ ret = -EINVAL;
+ } else {
+ *reg = RV1103_PULL_GPIO2_SARADC_OFFSET;
+ *bit = 13;
+
+ return 0;
+ }
+ break;
+
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ if (ret) {
+ printf("unsupported bank_num %d pin_num %d\n", bank->bank_num, pin_num);
+ return ret;
+ }
+
+ *reg += ((pin_num / RV1103_PULL_PINS_PER_REG) * 4);
+ *bit = pin_num % RV1103_PULL_PINS_PER_REG;
+ *bit *= RV1103_PULL_BITS_PER_PIN;
+
+ return 0;
+}
+
+static int rv1103b_set_pull(struct rockchip_pin_bank *bank,
+ int pin_num, int pull)
+{
+ struct regmap *regmap;
+ int reg, ret;
+ u8 bit, type;
+ u32 data, rmask;
+
+ if (pull == PIN_CONFIG_BIAS_PULL_PIN_DEFAULT)
+ return -EINVAL;
+
+ ret = rv1103b_calc_pull_reg_and_bit(bank, pin_num, ®map, ®, &bit);
+ if (ret)
+ return ret;
+ type = bank->pull_type[pin_num / 8];
+
+ if (bank->bank_num == 2 && pin_num >= 12)
+ type = 1;
+
+ ret = rockchip_translate_pull_value(type, pull);
+ if (ret < 0) {
+ debug("unsupported pull setting %d\n", pull);
+ return ret;
+ }
+
+ /* Enable the write to the equivalent lower bits */
+ data = ((1 << RV1103_PULL_BITS_PER_PIN) - 1) << (bit + 16);
+ rmask = data | (data >> 16);
+ data |= (ret << bit);
+
+ return regmap_update_bits(regmap, reg, rmask, data);
+}
+
+#define RV1103_SMT_BITS_PER_PIN 1
+#define RV1103_SMT_PINS_PER_REG 8
+#define RV1103_SMT_GPIO0_A_OFFSET 0x40400
+#define RV1103_SMT_GPIO0_B_OFFSET 0x50404
+#define RV1103_SMT_GPIO1_A01_OFFSET 0x410
+#define RV1103_SMT_GPIO1_A67_OFFSET 0x10410
+#define RV1103_SMT_GPIO2_OFFSET 0x30420
+#define RV1103_SMT_GPIO2_SARADC_OFFSET 0x3080C
+
+static int rv1103b_calc_schmitt_reg_and_bit(struct rockchip_pin_bank *bank,
+ int pin_num,
+ struct regmap **regmap,
+ int *reg, u8 *bit)
+{
+ struct rockchip_pinctrl_priv *priv = bank->priv;
+ int ret = 0;
+
+ *regmap = priv->regmap_base;
+ switch (bank->bank_num) {
+ case 0:
+ if (pin_num < 7)
+ *reg = RV1103_SMT_GPIO0_A_OFFSET;
+ else if (pin_num > 7 && pin_num < 14)
+ *reg = RV1103_SMT_GPIO0_B_OFFSET - 0x4;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 1:
+ if (pin_num < 6)
+ *reg = RV1103_SMT_GPIO1_A01_OFFSET;
+ else if (pin_num >= 6 && pin_num < 23)
+ *reg = RV1103_SMT_GPIO1_A67_OFFSET;
+ else if (pin_num >= 24 && pin_num < 30)
+ *reg = RV1103_SMT_GPIO1_A67_OFFSET;
+ else
+ ret = -EINVAL;
+ break;
+
+ case 2:
+ if (pin_num < 12) {
+ *reg = RV1103_SMT_GPIO2_OFFSET;
+ } else if (pin_num >= 16) {
+ ret = -EINVAL;
+ } else {
+ *reg = RV1103_SMT_GPIO2_SARADC_OFFSET;
+ *bit = 8;
+
+ return 0;
+ }
+ break;
+
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ if (ret) {
+ printf("unsupported bank_num %d pin_num %d\n", bank->bank_num, pin_num);
+ return ret;
+ }
+
+ *reg += ((pin_num / RV1103_SMT_PINS_PER_REG) * 4);
+ *bit = pin_num % RV1103_SMT_PINS_PER_REG;
+ *bit *= RV1103_SMT_BITS_PER_PIN;
+
+ return 0;
+}
+
+static int rv1103b_set_schmitt(struct rockchip_pin_bank *bank,
+ int pin_num, int enable)
+{
+ struct regmap *regmap;
+ int reg, ret;
+ u32 data, rmask, mask;
+ u8 bit;
+
+ ret = rv1103b_calc_schmitt_reg_and_bit(bank, pin_num, ®map, ®, &bit);
+ if (ret)
+ return ret;
+
+ mask = (1 << RV1103_SMT_BITS_PER_PIN) - 1;
+ if (bank->bank_num == 2 && pin_num >= 12) {
+ mask = 0x3;
+ enable = enable ? 0x3 : 0;
+ }
+
+ /* enable the write to the equivalent lower bits */
+ data = mask << (bit + 16);
+ rmask = data | (data >> 16);
+ data |= (enable << bit);
+
+ return regmap_update_bits(regmap, reg, rmask, data);
+}
+
+static struct rockchip_mux_recalced_data rv1103b_mux_recalced_data[] = {
+ {
+ .num = 1,
+ .pin = 6,
+ .reg = 0x10024,
+ .bit = 8,
+ .mask = 0xf
+ }, {
+ .num = 1,
+ .pin = 7,
+ .reg = 0x10024,
+ .bit = 12,
+ .mask = 0xf
+ },
+};
+
+static struct rockchip_pin_bank rv1103b_pin_banks[] = {
+ PIN_BANK_IOMUX_FLAGS_OFFSET(0, 32, "gpio0",
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ 0x40000, 0x50008, 0x50010, 0x50018),
+ PIN_BANK_IOMUX_FLAGS_OFFSET(1, 32, "gpio1",
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ 0x20, 0x10028, 0x10030, 0x10038),
+ PIN_BANK_IOMUX_FLAGS_OFFSET(2, 32, "gpio2",
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ IOMUX_WIDTH_4BIT,
+ 0x30040, 0x30048, 0x30050, 0x30058),
+};
+
+static const struct rockchip_pin_ctrl rv1103b_pin_ctrl = {
+ .pin_banks = rv1103b_pin_banks,
+ .nr_banks = ARRAY_SIZE(rv1103b_pin_banks),
+ .iomux_recalced = rv1103b_mux_recalced_data,
+ .niomux_recalced = ARRAY_SIZE(rv1103b_mux_recalced_data),
+ .set_mux = rv1103b_set_mux,
+ .set_pull = rv1103b_set_pull,
+ .set_drive = rv1103b_set_drive,
+ .set_schmitt = rv1103b_set_schmitt,
+};
+
+static const struct udevice_id rv1103b_pinctrl_ids[] = {
+ {
+ .compatible = "rockchip,rv1103b-pinctrl",
+ .data = (ulong)&rv1103b_pin_ctrl
+ },
+ { }
+};
+
+U_BOOT_DRIVER(pinctrl_rv1103b) = {
+ .name = "rockchip_rv1103b_pinctrl",
+ .id = UCLASS_PINCTRL,
+ .of_match = rv1103b_pinctrl_ids,
+ .priv_auto = sizeof(struct rockchip_pinctrl_priv),
+ .ops = &rockchip_pinctrl_ops,
+#if !CONFIG_IS_ENABLED(OF_PLATDATA)
+ .bind = dm_scan_fdt_dev,
+#endif
+ .probe = rockchip_pinctrl_probe,
+};
--
2.43.0
next prev parent reply other threads:[~2026-07-07 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 15:30 [PATCH v3 00/15] rockchip: Add support for the RV1103B, RV1103 and RV1106 Simon Glass
2026-07-07 15:30 ` [PATCH v3 01/15] ARM: dts: Add the RV1103B devicetree files Simon Glass
2026-07-07 15:31 ` Simon Glass [this message]
2026-07-07 15:31 ` [PATCH v3 03/15] clk: rockchip: Add RV1103B clock driver Simon Glass
2026-07-07 15:31 ` [PATCH v3 04/15] tools: rkcommon: Add RV1103B support Simon Glass
2026-07-07 15:31 ` [PATCH v3 05/15] rockchip: spl-boot-order: Add SPI NAND support Simon Glass
2026-07-07 15:31 ` [PATCH v3 06/15] spl: Add SPI NAND support via MTD in SPL Simon Glass
2026-07-07 15:31 ` [PATCH v3 07/15] rockchip: rv1103b: Add SoC support Simon Glass
2026-07-07 15:31 ` [PATCH v3 08/15] omega4-rv1103b: Add the initial support Simon Glass
2026-07-07 15:31 ` [PATCH v3 09/15] tools: rkcommon: Add RV1106 support Simon Glass
2026-07-07 15:31 ` [PATCH v3 10/15] pinctrl: rockchip: " Simon Glass
2026-07-07 15:31 ` [PATCH v3 11/15] ARM: dts: Add the RV1103/RV1106 devicetree files Simon Glass
2026-07-07 15:31 ` [PATCH v3 12/15] clk: rockchip: Add RV1106 clock driver Simon Glass
2026-07-07 15:31 ` [PATCH v3 13/15] rockchip: rv1106: Add SoC support Simon Glass
2026-07-07 15:31 ` [PATCH v3 14/15] luckfox-pico: Add the initial support Simon Glass
2026-07-07 15:31 ` [PATCH v3 15/15] rockchip: Support legacy images when booting from RAM Simon Glass
2026-07-07 15:35 ` [PATCH v3 00/15] rockchip: Add support for the RV1103B, RV1103 and RV1106 Tom Rini
2026-07-08 22:36 ` Simon Glass
2026-07-09 0:38 ` Tom Rini
2026-07-09 1:27 ` Simon Glass
2026-07-09 1:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707153135.2048115-3-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=festevam@nabladev.com \
--cc=hl@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox