Re: [PATCH v2] Makefile: depend on OF_LIST dts sources for fit-dtb.blob

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

On Fri, Jul 17, 2026 at 08:11:42AM -0600, Simon Glass wrote:
> Hi Lianghong,
> 
> On 2026-07-13T07:45:39, lianghong617 <liulhong617@163.com> wrote:
> > Makefile: depend on OF_LIST dts sources for fit-dtb.blob
> >
> > When CONFIG_MULTI_DTB_FIT is enabled, fit-dtb.blob is produced by
> > mkimage with one "-b <dtb>" argument for every entry in
> > CONFIG_OF_LIST.  The make rule, however, only listed dts/dt.dtb
> > (i.e. the CONFIG_DEFAULT_DEVICE_TREE blob) as a prerequisite:
> >
> >   fit-dtb.blob: dts/dt.dtb FORCE
> >       $(call if_changed,mkimage)
> >
> > Because FORCE is PHONY, if_changed ignores it and rebuilds only when
> > any-prereq or arg-check is non-empty.  Editing a non-default dts in
> > OF_LIST rebuilds its .dtb (tracked correctly via fixdep), but that
> > .dtb was not a prerequisite of fit-dtb.blob, so $? stayed empty; the
> > mkimage command line was unchanged too, so arg-check was empty as
> > well.  if_changed therefore skipped mkimage and fit-dtb.blob kept the
> > stale dtbs.  u-boot.bin, which appends fit-dtb.blob, then shipped the
> > old device tree and the dts change did not take effect.
> >
> > A previous attempt to fix this added every OF_LIST .dtb *output* as a
> > [...]
> >
> > Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> > Signed-off-by: lianghong617 <liulhong617@163.com>
> 
> Please can you use your real name in the Signed-off-by tag? Also we
> don't normally use bullet points in a commit message.

We don't (nor does the linux kernel) have a "real name" policy.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]