U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Md Shofiqul Islam <shofiqtest@gmail.com>
To: u-boot@lists.denx.de
Cc: Md Shofiqul Islam <shofiqtest@gmail.com>,
	Ian Ray <ian.ray@gehealthcare.com>,
	Wang Huan <b18965@freescale.com>,
	Brian Ruley <brian.ruley@gehealthcare.com>,
	Martyn Welch <martyn.welch@collabora.com>,
	Heiko Schocher <hs@nabladev.com>,
	Lukasz Majewski <lukma@nabladev.com>,
	Stefano Babic <sbabic@nabladev.com>,
	Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v3] board: imx6: guard LDB clock init with appropriate video config
Date: Tue, 28 Jul 2026 20:26:59 +0300	[thread overview]
Message-ID: <20260728172659.387624-1-shofiqtest@gmail.com> (raw)

Guard select_ldb_di_clock_source() in board_early_init_f() with the
correct video Kconfig symbol instead of calling it unconditionally.

- board/ge/b1x5v2: guard with CONFIG_SPL_VIDEO -- LDB init is needed
  in SPL only when display support is enabled
- board/aristainetos: guard with CONFIG_VIDEO_IPUV3 -- this board does
  not use SPL so CONFIG_SPL_VIDEO is not the right guard here

drivers/clk/imx/clk-imx6q.c already guards imx6q_init_ldb_clks() with
CONFIG_IS_ENABLED(VIDEO), so no change is needed there.

Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
---
v3: Rebased per Fabio's request. Dropped the other two changes from v2:
    - "imx6: clock: fix clk0/clk1 swap in select_ldb_di_clock_source()"
      is no longer needed; the same fix already landed in next.
    - The drivers/clk/imx/clk-imx6q.c guard hunk from patch 1/2 is no
      longer needed either; that call site is now guarded there with
      CONFIG_IS_ENABLED(VIDEO). Only the board-file guard below was
      still missing, so v3 is a single patch instead of two.

 board/aristainetos/aristainetos.c | 2 ++
 board/ge/b1x5v2/b1x5v2.c          | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/board/aristainetos/aristainetos.c b/board/aristainetos/aristainetos.c
index 4a2349e165b..c163b49209e 100644
--- a/board/aristainetos/aristainetos.c
+++ b/board/aristainetos/aristainetos.c
@@ -218,7 +218,9 @@ static void set_gpr_register(void)
 
 int board_early_init_f(void)
 {
+#if defined(CONFIG_VIDEO_IPUV3)
 	select_ldb_di_clock_source(MXC_PLL5_CLK, MXC_PLL5_CLK);
+#endif
 	set_gpr_register();
 
 	/*
diff --git a/board/ge/b1x5v2/b1x5v2.c b/board/ge/b1x5v2/b1x5v2.c
index f7751fd6fb1..da7cb880eeb 100644
--- a/board/ge/b1x5v2/b1x5v2.c
+++ b/board/ge/b1x5v2/b1x5v2.c
@@ -320,8 +320,9 @@ int overwrite_console(void)
 
 int board_early_init_f(void)
 {
+#if defined(CONFIG_SPL_VIDEO)
 	select_ldb_di_clock_source(MXC_PLL5_CLK, MXC_PLL5_CLK);
-
+#endif
 	return 0;
 }
 
-- 
2.51.1


             reply	other threads:[~2026-07-29  4:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 17:26 Md Shofiqul Islam [this message]
2026-07-29 18:39 ` [PATCH v3] board: imx6: guard LDB clock init with appropriate video config Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728172659.387624-1-shofiqtest@gmail.com \
    --to=shofiqtest@gmail.com \
    --cc=b18965@freescale.com \
    --cc=brian.ruley@gehealthcare.com \
    --cc=festevam@gmail.com \
    --cc=hs@nabladev.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=lukma@nabladev.com \
    --cc=martyn.welch@collabora.com \
    --cc=sbabic@nabladev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox