From: Tom Rini <trini@konsulko.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
Ion Agorria <ion@agorria.com>,
Aspeed BMC SW team <BMC-SW@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>,
u-boot@lists.u-boot-project.org, Chen-Yu Tsai <wens@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Simon Glass <sjg@chromium.org>,
Thierry Reding <treding@nvidia.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Quentin Schulz <u-boot@0leil.net>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Marek Vasut <marek.vasut@mailbox.org>,
Rasmus Villemoes <ravi@prevas.dk>,
Rasmus Villemoes <rv@rasmusvillemoes.dk>,
Aristo Chen <aristo.chen@canonical.com>,
Anton Ivanov <anton@binarly.io>,
Daniel Golle <daniel@makrotopia.org>,
Francois Berder <fberder@outlook.fr>, Peng Fan <peng.fan@nxp.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Randolph Sapp <rs@ti.com>, Jonas Karlman <jonas@kwiboo.se>,
Wolfgang Wallner <wolfgang.wallner@at.abb.com>,
Alexey Charkov <alchark@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Heiko Schocher <hs@nabladev.com>,
"Kory Maincent (TI.com)" <kory.maincent@bootlin.com>,
Anshul Dalal <anshuld@ti.com>, Johan Jonker <jbx6244@gmail.com>,
Francesco Valla <francesco@valla.it>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Michael Walle <mwalle@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
Lukasz Majewski <lukma@denx.de>,
Richard Genoud <richard.genoud@bootlin.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
E Shattow <e@freeshell.de>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Lucas Dietrich <ld.adecy@gmail.com>,
David Lechner <dlechner@baylibre.com>,
Julien Stephan <jstephan@baylibre.com>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
"Lucien.Jheng" <lucienzx159@gmail.com>,
Mateusz Furdyna <mateusz.furdyna@nokia.com>,
Dinesh Maniyam <dinesh.maniyam@altera.com>,
Heiko Stuebner <heiko@sntech.de>,
Vincent Jardin <vjardin@free.fr>
Subject: Re: [PATCH v6 03/13] crypto: hash: allow DM hash in SPL
Date: Tue, 28 Jul 2026 11:56:54 -0600 [thread overview]
Message-ID: <20260728175654.GF1188@bill-the-cat> (raw)
In-Reply-To: <20260728-submit-ce-series-v2-v6-3-80c1f7daffa5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Tue, Jul 28, 2026 at 11:41:46AM -0600, James Hilliard wrote:
> The hash uclass is currently keyed only by CONFIG_DM_HASH, so SPL cannot
> enable UCLASS_HASH independently. Any SPL code using hash_digest*() has to
> rely on U-Boot proper also enabling DM_HASH, and the FIT hash path selects
> the driver-model implementation with a non-phase-aware preprocessor check.
>
> Add SPL_DM_HASH, build the hash uclass from CONFIG_$(PHASE_)DM_HASH and use
> CONFIG_IS_ENABLED(DM_HASH) when selecting the FIT hash implementation. This
> lets SPL FIT verification use a UCLASS_HASH provider without requiring the
> U-Boot proper hash uclass.
>
> No in-tree configuration enables both DM_HASH and SPL_CRYPTO, so the
> Makefile object key switch does not remove hash-uclass.o from an existing
> SPL build.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-29 4:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 17:41 [PATCH v6 00/13] crypto: allwinner: enable sun8i-ce FIT crypto James Hilliard
2026-07-28 17:41 ` [PATCH v6 01/13] cmd: aes: fix DM operation handling James Hilliard
2026-07-28 17:41 ` [PATCH v6 02/13] crypto: aes: allow DM AES in SPL James Hilliard
2026-07-28 17:41 ` [PATCH v6 03/13] crypto: hash: allow DM hash " James Hilliard
2026-07-28 17:56 ` Tom Rini [this message]
2026-07-28 17:41 ` [PATCH v6 04/13] boot: image: try all DM hash providers James Hilliard
2026-07-28 17:41 ` [PATCH v6 05/13] crypto: aes: fix software key-size handling James Hilliard
2026-07-28 17:41 ` [PATCH v6 06/13] crypto: aes: add software-key provider dispatch James Hilliard
2026-07-28 17:41 ` [PATCH v6 07/13] boot: image: add FIT decrypt-to-buffer helper James Hilliard
2026-07-28 17:41 ` [PATCH v6 08/13] spl: fit: support encrypted payloads James Hilliard
2026-07-28 17:41 ` [PATCH v6 09/13] clk: sunxi: add H6/H616 CE gates and reset James Hilliard
2026-07-28 17:41 ` [PATCH v6 10/13] lib: ecdsa: support additional curve sizes James Hilliard
2026-07-28 17:41 ` [PATCH v6 11/13] crypto: allwinner: add sun8i-ce AES driver James Hilliard
2026-07-28 17:41 ` [PATCH v6 12/13] crypto: allwinner: add sun8i-ce ECDSA verifier James Hilliard
2026-07-28 17:41 ` [PATCH v6 13/13] crypto: allwinner: add sun8i-ce hash driver James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728175654.GF1188@bill-the-cat \
--to=trini@konsulko.com \
--cc=BMC-SW@aspeedtech.com \
--cc=alchark@gmail.com \
--cc=andre.przywara@arm.com \
--cc=anshuld@ti.com \
--cc=anton@binarly.io \
--cc=aristo.chen@canonical.com \
--cc=bastien.curutchet@bootlin.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=clamor95@gmail.com \
--cc=daniel@makrotopia.org \
--cc=dinesh.maniyam@altera.com \
--cc=dlechner@baylibre.com \
--cc=e@freeshell.de \
--cc=eballetbo@kernel.org \
--cc=fberder@outlook.fr \
--cc=francesco@valla.it \
--cc=heiko@sntech.de \
--cc=hs@nabladev.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ion@agorria.com \
--cc=james.hilliard1@gmail.com \
--cc=jbx6244@gmail.com \
--cc=joel@jms.id.au \
--cc=jonas@kwiboo.se \
--cc=jstephan@baylibre.com \
--cc=kory.maincent@bootlin.com \
--cc=ld.adecy@gmail.com \
--cc=lucienzx159@gmail.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marek.vasut@mailbox.org \
--cc=mateusz.furdyna@nokia.com \
--cc=michael@amarulasolutions.com \
--cc=mkorpershoek@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=ravi@prevas.dk \
--cc=raymond.mao@riscstar.com \
--cc=richard.genoud@bootlin.com \
--cc=rs@ti.com \
--cc=rv@rasmusvillemoes.dk \
--cc=ryan_chen@aspeedtech.com \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=treding@nvidia.com \
--cc=u-boot@0leil.net \
--cc=u-boot@lists.u-boot-project.org \
--cc=visitorckw@gmail.com \
--cc=vjardin@free.fr \
--cc=wens@kernel.org \
--cc=wolfgang.wallner@at.abb.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox