From: Yixun Lan <dlan@kernel.org>
To: Eric Chung <eric.chung@riscstar.com>
Cc: u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org,
Tom Rini <trini@konsulko.com>, Tim Ouyang <tim609@andestech.com>,
Leo Liang <leo.liang@sifive.com>, Peng Fan <peng.fan@nxp.com>,
Huan Zhou <pericycle.cc@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
Christoph Stoidner <c.stoidner@phytec.de>,
Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Angelo Dureghello <angelo@kernel-space.org>,
Johan Jonker <jbx6244@gmail.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Guodong Xu <guodong@riscstar.com>, Yao Zi <me@ziyao.cc>,
Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>
Subject: Re: [PATCH v8 04/11] pinctrl: k1: add IO power domain configuration support
Date: Mon, 17 Aug 2026 02:48:07 +0000 [thread overview]
Message-ID: <20260817024807-GKC566872@kernel.org> (raw)
In-Reply-To: <20260802-m4-v8-4-e916643205f3@riscstar.com>
Hi Eric,
On 00:40 Sun 02 Aug , Eric Chung wrote:
> Dual-voltage GPIO banks default to 3.3V, but when externally supplied
> with 1.8V the internal logic must be explicitly reconfigured to match.
>
> Add the ability to program IO power domain control registers through the
> APBC block. These registers require unlocking the AIB Secure Access
> Register (ASAR) before every read/write, since configuring a 1.8V domain
> while 3.3V is externally supplied can cause back-powering and pin damage.
>
> Signed-off-by: Eric Chung <eric.chung@riscstar.com>
> Reviewed-by: Yao Zi <me@ziyao.cc>
>
Looks good, please
Reviewed-by: Yixun Lan <dlan@kernel.org>
> ---
> v7:
> - Remove the dependency on SYSCON.
> v6:
> - Use dev_read_phandle_with_args() to fetch "spacemit,apbc" instead.
> v5:
> - Use tabs for macro definition alignment.
> - Fix the missing power source argument.
> v3:
> - Add SYSCON dependency in Kconfig.
> - Fix not sorted issue in the driver.
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-08-17 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 16:40 [PATCH v8 00/11] spacemit mmc driver Eric Chung
2026-08-01 16:40 ` [PATCH v8 01/11] spacemit: k1: select boot device via config registers Eric Chung
2026-08-01 16:40 ` [PATCH v8 02/11] pinctrl: k1: fix drive strength configuration Eric Chung
2026-08-17 2:12 ` Yixun Lan
2026-08-01 16:40 ` [PATCH v8 03/11] pinctrl: k1: fix pull-up/pull-down configuration Eric Chung
2026-08-17 1:39 ` Yixun Lan
2026-08-01 16:40 ` [PATCH v8 04/11] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-08-17 2:48 ` Yixun Lan [this message]
2026-08-01 16:40 ` [PATCH v8 05/11] mmc: k1: add sdhci platform driver Eric Chung
2026-08-01 16:40 ` [PATCH v8 06/11] dts: k1: add SD card support in u-boot overlay Eric Chung
2026-08-16 4:15 ` Yixun Lan
2026-08-01 16:40 ` [PATCH v8 07/11] configs: k1: enable SD and eMMC support Eric Chung
2026-08-01 16:40 ` [PATCH v8 08/11] MAINTAINER: update Spacemit K1 entry Eric Chung
2026-08-01 16:40 ` [PATCH v8 09/11] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-08-01 16:40 ` [PATCH v8 10/11] config: k1: enable ENV support for eMMC Eric Chung
2026-08-01 16:40 ` [PATCH v8 11/11] spacemit: k1: fix product name detection and DTB matching in SPL Eric Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817024807-GKC566872@kernel.org \
--to=dlan@kernel.org \
--cc=angelo@kernel-space.org \
--cc=anshuld@ti.com \
--cc=balsundar.ponnusamy@altera.com \
--cc=bastien.curutchet@bootlin.com \
--cc=bhimeswararao.matsa@gmail.com \
--cc=c.stoidner@phytec.de \
--cc=daniel@thingy.jp \
--cc=eric.chung@riscstar.com \
--cc=guodong@riscstar.com \
--cc=han.xu@nxp.com \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kauschluss@disroot.org \
--cc=leo.liang@sifive.com \
--cc=me@ziyao.cc \
--cc=peng.fan@nxp.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=rick@andestech.com \
--cc=semen.protsenko@linaro.org \
--cc=tanmay.kathpalia@altera.com \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
--cc=yanir.levin@tandemg.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox