From: Yixun Lan <dlan@kernel.org>
To: Junhui Liu <junhui.liu@pigmoral.tech>
Cc: Heiko Schocher <hs@nabladev.com>,
u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org,
Huan Zhou <pericycle.cc@gmail.com>,
Guodong Xu <guodong.xu@oss.qualcomm.com>,
Tom Rini <trini@konsulko.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Lukasz Majewski <lukma@denx.de>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Subject: Re: [PATCH v2 1/4] i2c: k1: fix wrong bus speed setting
Date: Mon, 17 Aug 2026 08:29:47 +0000 [thread overview]
Message-ID: <20260817082947-GKD566872@kernel.org> (raw)
In-Reply-To: <20260815-k1-i2c-fix-v2-1-7d2a48607233@pigmoral.tech>
hi Junhui,
On 11:40 Sat 15 Aug , Junhui Liu wrote:
> The controller bus mode should be selected according to the requested
> I2C bus speed. However, the driver currently passes the functional clock
> rate to k1_i2c_set_bus_speed(), so the selected mode does not reflect
> the requested bus speed.
>
> Fix this by reading the clock-frequency property from the Device Tree,
> defaulting to standard speed, and drop the unused clk_rate field.
>
> Fixes: 271546fb8e54 ("i2c: k1: add I2C driver support")
> Reviewed-by: Heiko Schocher <hs@nabladev.com>
> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> ---
> drivers/i2c/k1_i2c.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Looks good to me
Reviewed-by: Yixun Lan <dlan@kernel.org>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-08-17 13:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 3:40 [PATCH v2 0/4] i2c/clk: spacemit: k1: fix I2C bus configuration and clock handling Junhui Liu
2026-08-15 3:40 ` [PATCH v2 1/4] i2c: k1: fix wrong bus speed setting Junhui Liu
2026-08-17 8:29 ` Yixun Lan [this message]
2026-08-17 9:12 ` Troy Mitchell
2026-08-17 14:25 ` Junhui Liu
2026-08-18 1:03 ` Troy Mitchell
2026-08-15 3:40 ` [PATCH v2 2/4] clk: spacemit: k1: add TWSI bus clocks to SPL Junhui Liu
2026-08-15 3:40 ` [PATCH v2 3/4] i2c: k1: enable both functional and bus clocks Junhui Liu
2026-08-17 4:50 ` Heiko Schocher via U-Boot
2026-08-17 8:31 ` Yixun Lan
2026-08-17 8:56 ` Troy Mitchell
2026-08-17 9:18 ` Yixun Lan
2026-08-18 1:03 ` Troy Mitchell
2026-08-18 6:21 ` Yao Zi
2026-08-18 6:26 ` Yao Zi
2026-08-15 3:40 ` [PATCH v2 4/4] clk: spacemit: k1: remove bus gate from TWSI functional clocks Junhui Liu
2026-08-17 8:55 ` Troy Mitchell
2026-08-18 6:53 ` [PATCH v2 0/4] i2c/clk: spacemit: k1: fix I2C bus configuration and clock handling Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817082947-GKD566872@kernel.org \
--to=dlan@kernel.org \
--cc=guodong.xu@oss.qualcomm.com \
--cc=hs@nabladev.com \
--cc=junhui.liu@pigmoral.tech \
--cc=lukma@denx.de \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox