From: Frieder Schrempf <frieder@fris.de>
To: Stefano Babic <sbabic@nabladev.com>,
Fabio Estevam <festevam@gmail.com>, Tom Rini <trini@konsulko.com>,
u-boot@lists.u-boot-project.org
Cc: uboot-imx@nxp.com, Frieder Schrempf <frieder.schrempf@kontron.de>
Subject: [PATCH 2/4] ddr: imx: Move error message for failed training to calling side
Date: Wed, 19 Aug 2026 08:57:59 +0200 [thread overview]
Message-ID: <20260819065804.32156-2-frieder@fris.de> (raw)
In-Reply-To: <20260819065804.32156-1-frieder@fris.de>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
Move the error message from wait_ddrphy_training_complete() to the
calling site in ddr_cfg_phy(). This is more robust to future changes
in wait_ddrphy_training_complete() and allows us to make the message
optional.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
drivers/ddr/imx/phy/ddrphy_train.c | 4 +++-
drivers/ddr/imx/phy/ddrphy_utils.c | 1 -
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ddr/imx/phy/ddrphy_train.c b/drivers/ddr/imx/phy/ddrphy_train.c
index 63a6ca800a3..68468610fd6 100644
--- a/drivers/ddr/imx/phy/ddrphy_train.c
+++ b/drivers/ddr/imx/phy/ddrphy_train.c
@@ -72,8 +72,10 @@ int ddr_cfg_phy(struct dram_timing_info *dram_timing)
/* Wait for the training firmware to complete */
ret = wait_ddrphy_training_complete();
- if (ret)
+ if (ret) {
+ printf("Training FAILED\n");
return ret;
+ }
/* Halt the microcontroller. */
dwc_ddrphy_apb_wr(0xd0099, 0x1);
diff --git a/drivers/ddr/imx/phy/ddrphy_utils.c b/drivers/ddr/imx/phy/ddrphy_utils.c
index 8e350de8315..8779db01607 100644
--- a/drivers/ddr/imx/phy/ddrphy_utils.c
+++ b/drivers/ddr/imx/phy/ddrphy_utils.c
@@ -97,7 +97,6 @@ int wait_ddrphy_training_complete(void)
debug("Training PASS\n");
return 0;
} else if (mail == 0xff) {
- printf("Training FAILED\n");
return -1;
}
}
--
2.55.0
next prev parent reply other threads:[~2026-08-19 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 6:57 [PATCH 1/4] ddr: imx: Reload the training firmware for every PHY configuration Frieder Schrempf
2026-08-19 6:57 ` Frieder Schrempf [this message]
2026-08-19 6:58 ` [PATCH 3/4] ddr: imx: Allow to call ddr init without logging failure Frieder Schrempf
2026-08-19 10:03 ` Marek Vasut
2026-08-19 6:58 ` [PATCH 4/4] imx: kontron-sl-mx8mm: Stop printing error message on first DDR init Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819065804.32156-2-frieder@fris.de \
--to=frieder@fris.de \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=sbabic@nabladev.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox