U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.u-boot-project.org
Cc: Raymond Mao <raymondmaoca@gmail.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	David Feng <fenghua@phytium.com.cn>,
	Linus Walleij <linusw@kernel.org>,
	Peter Hoyes <Peter.Hoyes@arm.com>
Subject: [PATCH v2 2/2] vexpress64: Correct CONFIG symbol logic around device tree passage
Date: Mon, 24 Aug 2026 13:44:02 -0600	[thread overview]
Message-ID: <20260824194814.555634-3-trini@konsulko.com> (raw)
In-Reply-To: <20260824194814.555634-1-trini@konsulko.com>

When we don't have BLOBLIST_PASSAGE_MANDATORY enabled, then we're being
passed the device tree in some other manner, via OF_HAS_PRIOR_STAGE.
Correct our logic around which symbols are used to guard what is
generated / used and when.

Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Raymond Mao <raymondmaoca@gmail.com>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
Changes in v2:
- Add Ilias and Raymond's tags

Cc: David Feng <fenghua@phytium.com.cn>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Peter Hoyes <Peter.Hoyes@arm.com>
Cc: Raymond Mao <raymondmaoca@gmail.com>
---
 board/armltd/vexpress64/Kconfig      | 2 +-
 board/armltd/vexpress64/Makefile     | 2 ++
 board/armltd/vexpress64/vexpress64.c | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig
index 49c7fda0b83a..a988c7198498 100644
--- a/board/armltd/vexpress64/Kconfig
+++ b/board/armltd/vexpress64/Kconfig
@@ -31,7 +31,7 @@ choice
 config TARGET_VEXPRESS64_BASE_FVP
 	bool "Support Versatile Express ARMv8a FVP BASE model"
 	select VEXPRESS64_BASE_MODEL
-	imply OF_HAS_PRIOR_STAGE if !BLOBLIST
+	imply OF_HAS_PRIOR_STAGE
 
 config TARGET_VEXPRESS64_BASER_FVP
 	bool "Support Versatile Express ARMv8r64 FVP BASE model"
diff --git a/board/armltd/vexpress64/Makefile b/board/armltd/vexpress64/Makefile
index b0dd1d0af879..5f9dc2af930a 100644
--- a/board/armltd/vexpress64/Makefile
+++ b/board/armltd/vexpress64/Makefile
@@ -5,6 +5,8 @@
 
 obj-y	:= vexpress64.o
 
+ifeq ($(CONFIG_BLOBLIST_PASSAGE_MANDATORY),)
 obj-$(CONFIG_OF_HAS_PRIOR_STAGE)	+= lowlevel_init.o
+endif
 
 obj-$(CONFIG_TARGET_VEXPRESS64_JUNO)	+= pcie.o
diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c
index d68da0e3d650..8b6b96d757d5 100644
--- a/board/armltd/vexpress64/vexpress64.c
+++ b/board/armltd/vexpress64/vexpress64.c
@@ -97,7 +97,7 @@ int dram_init_banksize(void)
  * Push the variable into the .data section so that it
  * does not get cleared later.
  */
-#ifdef CONFIG_OF_HAS_PRIOR_STAGE
+#ifndef CONFIG_BLOBLIST_PASSAGE_MANDATORY
 unsigned long __section(".data") prior_stage_fdt_address[2];
 #endif
 
@@ -150,7 +150,7 @@ static phys_addr_t find_dtb_in_nor_flash(const char *partname)
 }
 #endif
 
-#ifdef CONFIG_OF_HAS_PRIOR_STAGE
+#ifndef CONFIG_BLOBLIST_PASSAGE_MANDATORY
 /*
  * Filter for a valid DTB, as TF-A happens to provide a pointer to some
  * data structure using the DTB format, which we cannot use.
-- 
2.43.0


  parent reply	other threads:[~2026-08-24 19:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08  1:25 [PATCH 0/7] Correct behavior of OF_OMIT_DTB Tom Rini
2026-07-08  1:25 ` [PATCH 1/7] lib/fdtdec.c: Disallow overriding the fdt address with mandatory passage Tom Rini
2026-07-08 16:26   ` Raymond Mao
2026-07-08 16:32     ` Tom Rini
2026-07-08 17:00       ` Tom Rini
2026-07-08  1:25 ` [PATCH 2/7] vexpress64: Correct CONFIG symbol logic around device tree passage Tom Rini
2026-07-08 16:27   ` Raymond Mao
2026-07-10  7:11   ` Ilias Apalodimas
2026-07-08  1:25 ` [PATCH 3/7] dts: Correct behavior of OF_OMIT_DTB Tom Rini
2026-07-08  1:25 ` [PATCH 4/7] dts: Make DEFAULT_DEVICE_TREE depend on !OF_OMIT_DTB Tom Rini
2026-07-08  1:25 ` [PATCH 5/7] dts: Correct entry for OF_OMIT_DTB Tom Rini
2026-07-08  1:25 ` [PATCH 6/7] powerpc: drop qemu-ppce500 dts Tom Rini
2026-07-08  1:25 ` [PATCH 7/7] arm: Drop unused dts files Tom Rini
2026-08-24 19:44 ` [PATCH v2 0/2] Correct behavior of BLOBLIST_PASSAGE_MANDATORY Tom Rini
2026-08-24 19:44   ` [PATCH v2 1/2] lib/fdtdec.c: Disallow overriding BLOBLIST_PASSAGE_MANDATORY Tom Rini
2026-08-26 15:45     ` Raymond Mao
2026-08-24 19:44   ` Tom Rini [this message]
2026-08-24 20:31     ` [PATCH v2 2/2] vexpress64: Correct CONFIG symbol logic around device tree passage Linus Walleij
2026-09-04  1:30   ` [PATCH v2 0/2] Correct behavior of BLOBLIST_PASSAGE_MANDATORY Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824194814.555634-3-trini@konsulko.com \
    --to=trini@konsulko.com \
    --cc=Peter.Hoyes@arm.com \
    --cc=fenghua@phytium.com.cn \
    --cc=ilias.apalodimas@linaro.org \
    --cc=linusw@kernel.org \
    --cc=raymondmaoca@gmail.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox