From: Sriram Sriram <sriramsriram@linux.microsoft.com>
To: u-boot@lists.u-boot-project.org
Cc: Michal Simek <michal.simek@amd.com>,
Tom Rini <trini@konsulko.com>,
Drew Kluemke <ankluemk@microsoft.com>,
Sriram Sriram <sriramsriram@linux.microsoft.com>
Subject: [PATCH 2/2] board: xilinx: Make ft_board_setup() weak
Date: Wed, 9 Sep 2026 12:20:47 -0700 [thread overview]
Message-ID: <20260909192047.217421-3-sriramsriram@linux.microsoft.com> (raw)
In-Reply-To: <20260909192047.217421-1-sriramsriram@linux.microsoft.com>
board/xilinx/common/board.c is linked into every board that uses the
xilinx vendor common library, so the strong ft_board_setup() defined
here prevents an individual board from applying its own device tree
fixups: adding ft_board_setup() to the board file fails to link with
"multiple definition of ft_board_setup".
Mark it __weak, which is the mechanism this file already uses for its
other board hooks - board_name_decode(), board_detection(),
soc_detection() and board_rng_seed(). No other weak definition of
ft_board_setup() exists in the tree, so boards without an override keep
linking this implementation and symbol resolution stays unambiguous.
Signed-off-by: Sriram Sriram <sriramsriram@linux.microsoft.com>
---
board/xilinx/common/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c
index 690991bb435..0e765cc81b4 100644
--- a/board/xilinx/common/board.c
+++ b/board/xilinx/common/board.c
@@ -695,7 +695,7 @@ int embedded_dtb_select(void)
#ifdef CONFIG_OF_BOARD_SETUP
#define MAX_RAND_SIZE 8
-int ft_board_setup(void *blob, struct bd_info *bd)
+int __weak ft_board_setup(void *blob, struct bd_info *bd)
{
static const struct node_info nodes[] = {
{ "arm,pl353-nand-r2p1", MTD_DEV_TYPE_NAND, },
--
2.49.0
next prev parent reply other threads:[~2026-09-09 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 19:20 [PATCH 0/2] board: xilinx: Fix board name overflow and allow board ft_board_setup() Sriram Sriram
2026-09-09 19:20 ` [PATCH 1/2] board: xilinx: Use strlcat() in board_name_decode() Sriram Sriram
2026-09-10 7:56 ` Maarten Brock
2026-09-10 7:59 ` Michal Simek
2026-09-10 8:03 ` Michal Simek
2026-09-10 9:30 ` Maarten Brock
2026-09-10 9:43 ` Michal Simek
2026-09-15 19:24 ` Sriram Sriram
2026-09-16 8:06 ` Michal Simek
2026-09-09 19:20 ` Sriram Sriram [this message]
2026-09-16 17:36 ` [PATCH v2 0/2] board: xilinx: board_name_decode() allocation fix and weak ft_board_setup() Sriram Sriram
2026-09-16 17:36 ` [PATCH v2 1/2] board: xilinx: Check calloc() result in board_name_decode() Sriram Sriram
2026-09-16 17:36 ` [PATCH v2 2/2] board: xilinx: Make ft_board_setup() weak Sriram Sriram
2026-09-25 13:51 ` [PATCH v2 0/2] board: xilinx: board_name_decode() allocation fix and weak ft_board_setup() Michal Simek
2026-09-28 22:13 ` Sriram Sriram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909192047.217421-3-sriramsriram@linux.microsoft.com \
--to=sriramsriram@linux.microsoft.com \
--cc=ankluemk@microsoft.com \
--cc=michal.simek@amd.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox