Re: [PATCH v1 1/2] imx: mach: imx8: fdt: return libfdt errors from helpers

[Francesco Dolcini <francesco@dolcini.it>]

On Mon, Oct 19, 2026 at 02:58:52PM +0200, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> delete_node() and change_property() replaced the libfdt error codes with
> -ENXIO and -EINVAL, but the callers pass the result to fdt_strerror(),
> which expects a libfdt error code. In addition,
> update_fdt_gpu_industrial_frequencies() compared the result against the
> positive ENXIO, so a missing node was reported as an error instead of
> being ignored.
> 
> On an industrial i.MX 8 booted with a device tree that lacks the GPU1
> nodes (e.g. mainline Linux), a misleading error is printed on every boot
> because -ENXIO is interpreted by fdt_strerror() as a libfdt error code,
> e.g.:
> 
>     Failed to set assigned-clock-rates for GPU1: FDT_ERR_BADPHANDLE
> 
> Return the libfdt error codes unchanged and ignore -FDT_ERR_NOTFOUND,
> which fdt_path_offset() returns if the node does not exist.
> 
> Fixes: e9cf7f515a19 ("imx: mach: imx8: fdt: set correct frequencies for the industrial SoC")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>