From: Yixun Lan <dlan@kernel.org>
To: Eric Chung <eric.chung@riscstar.com>
Cc: Dave Klotz <DaveWK225@protonmail.com>,
u-boot@lists.u-boot-project.org,
Huan Zhou <pericycle.cc@gmail.com>, Tom Rini <trini@konsulko.com>,
Guodong Xu <guodong@riscstar.com>,
Raymond Mao <raymond.mao@riscstar.com>,
u-boot-spacemit@groups.io
Subject: Re: [PATCH 2/2] spacemit: k1: fall back to the other boot devices in SPL
Date: Thu, 22 Oct 2026 23:06:25 +0000 [thread overview]
Message-ID: <20261022230625-GKC125937@kernel.org> (raw)
In-Reply-To: <CAH22mJyBGC1pN93yuNX-utLOfw=vsq9METWngqwqJ52xaA4jag@mail.gmail.com>
Hi Eric,
On 16:15 Mon 19 Oct , Eric Chung wrote:
> On Sat, Oct 3, 2026 at 5:31 AM Dave Klotz <DaveWK225@protonmail.com> wrote:
> >
> > spl_boot_device() derives the boot device from BootROM state: the SD
> > API pointer the BootROM leaves in SRAM, the boot flag register, and the
> > boot strap. Not every BootROM path is covered by that. On the OrangePi
> > R2S, for example, the BootROM probes a card first ("try sd...") and only
> > then loads the FSBL from eMMC, and on the OrangePi RV2 it falls back
> > from the card to SPI NOR. If the detection names a device that holds no
> > image, the SPL stops with "failed to boot from all boot devices".
> >
> > Provide board_boot_order(): the detected device first, then the other
> > MMC controller and SPI NOR when this SPL can read them.
> >
> > Signed-off-by: Dave Klotz <DaveWK225@protonmail.com>
> > ---
..
>
> Reviewed-by: Eric Chung <eric.chung@riscstar.com>
This thread is broken, and Dave has sent out a new one..
Thanks for the review tag, I will added it manually when queue this patch.
no need to resend
https://lore.kernel.org/all/cover.1790976767.git.DaveWK225@protonmail.com/
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-10-22 23:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 21:30 [PATCH 0/9] pci: spacemit: fixes for the K1 PCIe host driver Dave Klotz
2026-10-02 21:30 ` [PATCH 1/9] pci: spacemit: power the slot from vpcie3v3-supply Dave Klotz
2026-10-19 8:32 ` Eric Chung
2026-10-02 21:30 ` [PATCH 2/9] pci: spacemit: hold the PHY interface in reset until link start Dave Klotz
2026-10-19 8:36 ` Eric Chung
2026-10-02 21:30 ` [PATCH 3/9] pci: spacemit: soft reset the controller before bring-up Dave Klotz
2026-10-19 8:43 ` Eric Chung
2026-10-02 21:30 ` [PATCH 4/9] pci: spacemit: check clock, reset and iATU setup results Dave Klotz
2026-10-19 8:48 ` Eric Chung
2026-10-02 21:31 ` [PATCH 5/9] pci: spacemit: report link up from the link status register Dave Klotz
2026-10-19 8:50 ` Eric Chung
2026-10-02 21:31 ` [PATCH 6/9] pci: spacemit: do not force the link to 2.5 GT/s Dave Klotz
2026-10-19 9:42 ` Eric Chung
2026-10-02 21:31 ` [PATCH 7/9] pci: spacemit: do not advertise ASPM L1 Dave Klotz
2026-10-19 9:43 ` Eric Chung
2026-10-02 21:31 ` [PATCH 8/9] pci: spacemit: set the link width from num-lanes Dave Klotz
2026-10-19 9:43 ` Eric Chung
2026-10-02 21:31 ` [PATCH 9/9] pci: spacemit: do not fail the probe when the link is down Dave Klotz
2026-10-19 9:45 ` Eric Chung
2026-10-02 21:31 ` [PATCH 0/2] spacemit: k1: SPL robustness for boards without a PMIC or SPI NOR Dave Klotz
2026-10-02 21:31 ` [PATCH 1/2] spacemit: k1: do not require a PMIC or an SPI controller in SPL Dave Klotz
2026-10-19 8:14 ` Eric Chung
2026-10-02 21:31 ` [PATCH 2/2] spacemit: k1: fall back to the other boot devices " Dave Klotz
2026-10-19 8:15 ` Eric Chung
2026-10-22 23:06 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022230625-GKC125937@kernel.org \
--to=dlan@kernel.org \
--cc=DaveWK225@protonmail.com \
--cc=eric.chung@riscstar.com \
--cc=guodong@riscstar.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox