From: Neha Malcom Francis <n-francis@ti.com>
To: Andrew Davis <afd@ti.com>, <sjg@chromium.org>,
<marcel.ziswiler@toradex.com>
Cc: <u-boot@lists.denx.de>, <vigneshr@ti.com>, <nm@ti.com>,
<u-kumar1@ti.com>, <kamlesh@ti.com>, <m-chawdhry@ti.com>,
<mkorpershoek@baylibre.com>
Subject: Re: [PATCH 2/2] arm: dts: k3-*-binman: Move to using templated FITs
Date: Thu, 16 Nov 2023 10:38:00 +0530 [thread overview]
Message-ID: <202d11af-b2f2-412a-b9be-0e25174185d5@ti.com> (raw)
In-Reply-To: <1beed541-c7bd-4ed0-943f-c3695ee1db93@ti.com>
Hi Andrew,
On 15/11/23 21:22, Andrew Davis wrote:
> On 11/15/23 4:10 AM, Neha Malcom Francis wrote:
>> Reduce redundancy in code by using templates to generate the A72 boot
>> binaries (tispl.bin and u-boot.img) as well as R5 boot binary sysfw.itb
>> (for legacy boot following devices J721E and AM65x).
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
>> ---
>> arch/arm/dts/k3-am625-sk-binman.dtsi | 157 +--------
>> .../dts/k3-am625-verdin-wifi-dev-binman.dtsi | 155 +-------
>> arch/arm/dts/k3-am62a-sk-binman.dtsi | 158 +--------
>> arch/arm/dts/k3-am64x-binman.dtsi | 151 +-------
>> arch/arm/dts/k3-am65x-binman.dtsi | 273 +-------------
>> arch/arm/dts/k3-j7200-binman.dtsi | 159 +--------
>> arch/arm/dts/k3-j721e-binman.dtsi | 332 +-----------------
>> arch/arm/dts/k3-j721s2-binman.dtsi | 157 +--------
>> 8 files changed, 54 insertions(+), 1488 deletions(-)
>
> 1488 deletions, nice!
>
> Minor question, why was `ti-secure` not factored out of `dm` nodes like
> it was for `atf`/`tee` nodes? Guessing it has to do with not all SoCs
> needing this blob and signing nothing results in something, which
> messes up the 0 size check when loading it, but it wasn't clear to me.
>
Yes that's right! It ends up being non-zero for devices that don't have DM and
DM load fails.
> Anyway,
>
> Acked-by: Andrew Davis <afd@ti.com>
--
Thanking You
Neha Malcom Francis
next prev parent reply other threads:[~2023-11-16 5:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 10:10 [PATCH 0/2] Cleanup K3 binman FIT images Neha Malcom Francis
2023-11-15 10:10 ` [PATCH 1/2] arm: dts: k3-binman: Add support for FIT templates Neha Malcom Francis
2023-11-16 16:03 ` Simon Glass
2023-11-16 16:43 ` Marcel Ziswiler
2023-11-17 5:15 ` Neha Malcom Francis
2023-11-22 20:50 ` Tom Rini
2023-11-15 10:10 ` [PATCH 2/2] arm: dts: k3-*-binman: Move to using templated FITs Neha Malcom Francis
2023-11-15 15:52 ` Andrew Davis
2023-11-16 5:08 ` Neha Malcom Francis [this message]
2023-11-16 16:04 ` Simon Glass
2023-11-22 5:20 ` Manorit Chawdhry
2023-11-22 5:52 ` Neha Malcom Francis
2023-11-22 20:50 ` Tom Rini
2023-11-15 17:33 ` [PATCH 0/2] Cleanup K3 binman FIT images Marcel Ziswiler
2023-11-16 5:08 ` Neha Malcom Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202d11af-b2f2-412a-b9be-0e25174185d5@ti.com \
--to=n-francis@ti.com \
--cc=afd@ti.com \
--cc=kamlesh@ti.com \
--cc=m-chawdhry@ti.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mkorpershoek@baylibre.com \
--cc=nm@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox