public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2] test/py: test_efi_fit: Update #size-cells to 1
Date: Sun, 28 Jun 2020 14:23:09 +0200	[thread overview]
Message-ID: <2040e0b4-9e55-a60e-e09e-e1ebfc1abc29@gmx.de> (raw)
In-Reply-To: <1593306197-26574-1-git-send-email-bmeng.cn@gmail.com>

On 6/28/20 3:03 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> test_efi_fit tests fail on RISC-V currently. This is due to the
> RISC-V arch_fixup_fdt() checks the #size-cells of the root node
> in order to correctly fix up the reserved memory node.
>
> Per the DT binding, the /reserved-memory node requires both
> <#address-cells> and <#size-cells> and they should use the same
> values as the root node. For the root node, it's not very useful
> if <#size-cells> is zero.

The text you refer to is Linux's
Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt

Will you also fix the underlying problem that the /reserved-memory node
does not provide its own #address-cells, #size-cells?

>
> Update #size-cells to 1 so tests can pass.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> Changes in v2:
> - Update the reset node's <reg> property to contain a size
>
>  test/py/tests/test_efi_fit.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/py/tests/test_efi_fit.py b/test/py/tests/test_efi_fit.py
> index beaf4a3..06fb151 100644
> --- a/test/py/tests/test_efi_fit.py
> +++ b/test/py/tests/test_efi_fit.py
> @@ -106,14 +106,14 @@ FDT_DATA = '''
>
>  / {
>      #address-cells = <1>;
> -    #size-cells = <0>;
> +    #size-cells = <1>;
>
>      model = "%(sys-arch)s %(fdt_type)s EFI FIT Boot Test";
>      compatible = "%(sys-arch)s";
>
>      reset at 0 {
>          compatible = "%(sys-arch)s,reset";
> -        reg = <0>;
> +        reg = <0 4>;

This reg property is not used by any driver. I think it was only added
to avoid a dtc warning.

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

>      };
>  };
>  '''
>

  reply	other threads:[~2020-06-28 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28  1:03 [PATCH v2] test/py: test_efi_fit: Update #size-cells to 1 Bin Meng
2020-06-28 12:23 ` Heinrich Schuchardt [this message]
2020-06-29  0:26   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2040e0b4-9e55-a60e-e09e-e1ebfc1abc29@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox