public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabresd: Fix mmc boot by making USDHC3 be 'dev	0'
Date: Thu, 10 Jan 2013 15:43:24 +0100 (CET)	[thread overview]
Message-ID: <206033084.492777.1357829004487.JavaMail.root@advansee.com> (raw)
In-Reply-To: <1357828345-9076-1-git-send-email-fabio.estevam@freescale.com>

Hi Fabio,

On Thursday, January 10, 2013 3:32:25 PM, Fabio Estevam wrote:
> By default, we boot from USDHC3 on mx6qsabresd, so let it be mmc dev
> 0.
> 
> Without this fix kernel cannot be retrieved from mmc with the default
> environment.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6qsabresd/mx6qsabresd.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/freescale/mx6qsabresd/mx6qsabresd.c
> b/board/freescale/mx6qsabresd/mx6qsabresd.c
> index 65c4a1a..fbcb6cd 100644
> --- a/board/freescale/mx6qsabresd/mx6qsabresd.c
> +++ b/board/freescale/mx6qsabresd/mx6qsabresd.c
> @@ -134,8 +134,8 @@ static void setup_iomux_uart(void)
>  
>  #ifdef CONFIG_FSL_ESDHC
>  struct fsl_esdhc_cfg usdhc_cfg[3] = {
> -	{USDHC2_BASE_ADDR},
>  	{USDHC3_BASE_ADDR},
> +	{USDHC2_BASE_ADDR},
>  	{USDHC4_BASE_ADDR},
>  };
>  
> @@ -162,13 +162,13 @@ int board_mmc_init(bd_t *bis)
>  
>  	for (i = 0; i < CONFIG_SYS_FSL_USDHC_NUM; i++) {
>  		switch (i) {
> -		case 0:
> +		case 1:
>  			imx_iomux_v3_setup_multiple_pads(
>  				usdhc2_pads, ARRAY_SIZE(usdhc2_pads));
>  			gpio_direction_input(USDHC2_CD_GPIO);
>  			usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);
                                  ^ should be changed to 1 or i

>  			break;
> -		case 1:
> +		case 0:
>  			imx_iomux_v3_setup_multiple_pads(
>  				usdhc3_pads, ARRAY_SIZE(usdhc3_pads));
>  			gpio_direction_input(USDHC3_CD_GPIO);

Ditto (with 0 or i) for the following hidden lines.

Best regards,
Beno?t

  reply	other threads:[~2013-01-10 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 14:32 [U-Boot] [PATCH] mx6qsabresd: Fix mmc boot by making USDHC3 be 'dev 0' Fabio Estevam
2013-01-10 14:43 ` Benoît Thébaudeau [this message]
2013-01-10 15:44   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=206033084.492777.1357829004487.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox