From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ZFS: fix some warnings, cleanup
Date: Tue, 16 Oct 2012 15:38:32 +0200 [thread overview]
Message-ID: <2084016.xjRaiQnTOB@bloomfield> (raw)
In-Reply-To: <20121016003347.GK25082@bill-the-cat>
Hi
On Monday 15 of October 2012 17:33:47 Tom Rini wrote:
> On Wed, Sep 19, 2012 at 05:32:36PM +0200, Pavel Herrmann wrote:
> > Fix warnings about type mismatch in cmd_zfs.
> > Dont use a global block_dev_desc, instead use a local one in each cmd.
> >
> > Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
>
> [snip]
>
> > -static int do_zfs_load(cmd_tbl_t *cmdtp, int flag, int argc, char
> > *argv[])
> > +static int do_zfs_load(cmd_tbl_t *cmdtp, int flag, int argc,
> > + char * const argv[])
>
> That's a checkpatch warning, please fix.
>
> > -static int do_zfs_ls(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> > +static int do_zfs_ls(cmd_tbl_t *cmdtp, int flag, int argc, char * const
> > argv[])
> Same.
This patch is no longer relevant, as the important bits have been merged in
next by Rob Herring as a part of the get_device_and_partition patch
Pavel Herrmann
prev parent reply other threads:[~2012-10-16 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 15:32 [U-Boot] [PATCH] ZFS: fix some warnings, cleanup Pavel Herrmann
2012-09-23 15:31 ` Pavel Herrmann
2012-09-23 15:38 ` Marek Vasut
2012-10-16 0:33 ` Tom Rini
2012-10-16 13:38 ` Pavel Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2084016.xjRaiQnTOB@bloomfield \
--to=morpheus.ibis@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox