From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Date: Sat, 13 Feb 2021 23:45:50 +0100 Subject: [PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR In-Reply-To: <20210213155901.10247-1-royger@FreeBSD.org> References: <20210213155901.10247-1-royger@FreeBSD.org> Message-ID: <20953434.EfDdHjke4D@phil> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Roger, Am Samstag, 13. Februar 2021, 16:59:01 CET schrieb Roger Pau Monne: > From: Roger Pau Monn? > > Using a non-default SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR setting makes the > resulting u-boot-rockchip.bin unbootable, as it gets stuck after SPL. > Removing the setting from the defconfig allows U-Boot to load > successfully. Hmm, I'd disagree slightly. In the rockchip-common.h the CONFIG_SPL_PAD_TO is defined as /* ((CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512) */ #define CONFIG_SPL_PAD_TO 8355840 so it's a static value but based on the MMCSD_RAW_MODE... config option. So instead of mandating one specific MMCSD_RAW_MODE... value that CONFIG_SPL_PAD_TO should be defined based on the the actual config value of CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR and not some static number that then gets enforced for all boards. Heiko > > Signed-off-by: Roger Pau Monn? > --- > Cc: Heiko Stuebner > --- > configs/odroid-go2_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig > index 853890901a..5632b15611 100644 > --- a/configs/odroid-go2_defconfig > +++ b/configs/odroid-go2_defconfig > @@ -33,7 +33,6 @@ CONFIG_SPL_BOOTROM_SUPPORT=y > # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set > CONFIG_SPL_STACK_R=y > # CONFIG_TPL_BANNER_PRINT is not set > -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200 > CONFIG_SPL_CRC32_SUPPORT=y > CONFIG_SPL_I2C_SUPPORT=y > CONFIG_SPL_POWER_SUPPORT=y >