From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Wed, 10 Aug 2011 13:58:27 +0530 (IST)
Subject: [U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC
	Armada100
In-Reply-To: <1874942368.72721.1312964851129.JavaMail.root@ahm.einfochips.com>
Message-ID: <2096251420.72726.1312964907867.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: Wednesday, August 10, 2011 1:37 PM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> > Subject: Re: [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC
> > Armada100
> > 
> > 
> > ----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:
> > 
> > >
> > > I suggest below code for this function.
> > > {
> > >   Const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio
> register
> > > bank offsets */
> > >   return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
> > > }
> > >
> > > Again content in this file are SoC core specific and will
> duplicate
> > > for other SoC supports like pantheon.
> > >
> > > Can you please move them to mvgpio.h within #ifdef
> > > CONFIG_SHEEVA_88SV331xV5?
> > > I think this should be the final modification for this driver
> > > support.
> > >
> > > Sorry for the rework.
> > >
> > > Regards..
> > > Prafulla . .
> > >
> > 
> > Hi Prafulla,
> > 
> > Can you please tell me what part of code should be moved to
> mvgpio.h?
> 
> You should move entire contents of gpio.h in mvgpio.h within #ifdef
> CONFIG_SHEEVA_88SV331xV5, so just mvgpio.c,mvgpio.h,Makefile will add
> armada100 gpio driver support in more generic way.
> 
> > I have no idea about number of banks in other SOCs with same core.
> 
> No need to worry, at this moment this driver will be supporting
> 88SV331xv5 core only.
> 
> Regards..
> Prafulla . .
> 
I feel it is important to keep gpio.h in arch folder, 'coz if someone enables
GPIO command support, generic library header (asm/gpio.h) will look for
asm/arch/gpio.h file. we can simply include mvgpio.h in gpio.h incase of armada100.

Regards,
Ajay Bhargav