From: Philippe REYNES <philippe.reynes@softathome.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] cmd/button: return button status
Date: Fri, 4 Sep 2020 10:44:25 +0200 (CEST) [thread overview]
Message-ID: <2096905806.243676.1599209065796.JavaMail.zimbra@softathome.com> (raw)
In-Reply-To: <20200902200826.97874-1-xypron.glpk@gmx.de>
> To make the button command useful in a shell script it should return the
> status of the button:
>
> * 0 (true) - pressed, on
> * 1 (false) - not pressed, off
>
> The button command takes only one argument. Correct maxargs.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
> cmd/button.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/button.c b/cmd/button.c
> index 84ad1653c7..64c5a8fa04 100644
> --- a/cmd/button.c
> +++ b/cmd/button.c
> @@ -75,11 +75,11 @@ int do_button(struct cmd_tbl *cmdtp, int flag, int argc,
> char *const argv[])
>
> ret = show_button_state(dev);
>
> - return 0;
> + return !ret;
> }
>
> U_BOOT_CMD(
> - button, 4, 1, do_button,
> + button, 2, 1, do_button,
> "manage buttons",
> "<button_label> \tGet button state\n"
> "button list\t\tShow a list of buttons"
> --
> 2.28.0
next prev parent reply other threads:[~2020-09-04 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 20:08 [PATCH 1/1] cmd/button: return button status Heinrich Schuchardt
2020-09-04 8:44 ` Philippe REYNES [this message]
2020-09-12 14:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2096905806.243676.1599209065796.JavaMail.zimbra@softathome.com \
--to=philippe.reynes@softathome.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox