public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Haijun Qin" <qinhaijun@eswincomputing.com>
To: "Simon Glass" <sjg@chromium.org>
Cc: u-boot@lists.denx.de, zhuwenjun@eswincomputing.com,
	 zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com,
	 zhangdongdong@eswincomputing.com
Subject: Re: Re: [PATCH] lib: rsa: cosmetic: fix building warning
Date: Wed, 7 Dec 2022 11:10:51 +0800 (GMT+08:00)	[thread overview]
Message-ID: <2097adff.c1b4.184ea908930.Coremail.qinhaijun@eswincomputing.com> (raw)
In-Reply-To: <CAPnjgZ2fsuPyt=sNxTGDXR-5ZVmGrmb+71KM8PxORDjUa3oHFw@mail.gmail.com>

Hi,Simon

The toolchain source code we use comes from here(https://github.com/riscv-collab/riscv-gnu-toolchain), but we have made some changes.

> On Wed, 7 Dec 2022 at 03:50, Haijun Qin <qinhaijun@eswincomputing.com> wrote:
> >
> > add initialization of variable 'node',this can aviod the building
> > warning:
> >
> >     'node' may be used uninitialized [-Wmaybe-uninitialized]
> >
> > Signed-off-by: Haijun Qin <qinhaijun@eswincomputing.com>
> > ---
> >  lib/rsa/rsa-sign.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> What toolchain is this?
> 
> 
> >
> > diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c
> > index b2a21199e4..d20bdb58a5 100644
> > --- a/lib/rsa/rsa-sign.c
> > +++ b/lib/rsa/rsa-sign.c
> > @@ -608,7 +608,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest)
> >         BIGNUM *modulus, *r_squared;
> >         uint64_t exponent;
> >         uint32_t n0_inv;
> > -       int parent, node;
> > +       int parent, node = -FDT_ERR_NOTFOUND;
> >         char name[100];
> >         int ret;
> >         int bits;
> >
> > base-commit: d2c5607edde2544e059fa871927877213f6bd532
> > --
> > 2.17.1
> >

  reply	other threads:[~2022-12-07  3:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  7:41 [PATCH] lib: rsa: cosmetic: fix building warning Haijun Qin
2022-12-07  1:08 ` Simon Glass
2022-12-07  3:10   ` Haijun Qin [this message]
2023-01-12 15:17 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2097adff.c1b4.184ea908930.Coremail.qinhaijun@eswincomputing.com \
    --to=qinhaijun@eswincomputing.com \
    --cc=jinyanjiang@eswincomputing.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=zhangdongdong@eswincomputing.com \
    --cc=zhengyu@eswincomputing.com \
    --cc=zhuwenjun@eswincomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox