From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Sat, 11 Aug 2012 20:07:36 +0200 (CEST) Subject: [U-Boot] [PATCH 4/5] README: The ver env var is not read-only In-Reply-To: <201208111348.25632.vapier@gentoo.org> Message-ID: <2098801045.2303154.1344708456703.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 11 August 2012 19:48:24 Mike Frysinger wrote: > On Friday 10 August 2012 13:45:57 Beno?t Th?baudeau wrote: > > --- u-boot-4d3c95f.orig/README > > +++ u-boot-4d3c95f/README > > > > If this variable is defined, an environment variable > > named "ver" is created by U-Boot showing the U-Boot > > version as printed by the "version" command. > > - This variable is readonly. > > why don't we fix it to be read-only ? > -mike I had thought about that, but there is an issue. main_loop() sets this env var, so if ver is made read-only and the env is stored somewhere (NVRAM, etc.), then after an update of U-Boot with a newer version (stored env untouched), ver will still indicate the older version. See commit 155cb01, which forgot to update the README file, which my patch does. Best regards, Beno?t