[U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD

Prafulla Wadaskar
2011-07-08T14:59:48Z

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Friday, July 08, 2011 6:19 PM
> To: Wolfgang Denk
> Cc: Prafulla Wadaskar; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for
> Marvell gplugD
>
> Dear Wolfgang,
>
> > Bad examples are no excuse for adding more bad code.
> got it :)
>
> > Some things only get noticed when they already exist. But once
> > noticed, we should not repeat the same mistakes.
>
> I wouldn't have tried making that mistake if it was mentioned that
> earlier implementations are wrong. I just thought its a simple way to
> do a complex thing :)

Hi Ajay
You may find similar implementation for other architectures also (old code).
It doesn't mean earlier implementation is wrong.

This is a development policy, we encourage c-struct for register definition for any new code submission.

Regards..
Prafulla . .