From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9B16C47DDB for ; Mon, 29 Jan 2024 18:26:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6992F87C52; Mon, 29 Jan 2024 19:26:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="TgtU51nz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0A61587C68; Mon, 29 Jan 2024 19:26:43 +0100 (CET) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E6EE087C4C for ; Mon, 29 Jan 2024 19:26:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=a-nandan@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40TIQVNj092029; Mon, 29 Jan 2024 12:26:31 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1706552791; bh=CIkrAEITL4sQsjkLCCCX1oLHP/v5sLe1qIw0j3CD0T0=; h=Date:Subject:To:References:From:In-Reply-To; b=TgtU51nzLP1ORFG9F9dkC3+zQoxLdf0ISnqbk8TquB9Fh/mHovcuH0F/FCY1ofSMK hXDJXPaul/XXiPN+vCjqZUxuKdpj5ErbRdltxsj2kd+j37QKI7FEgSqkvaRGq2GEVD Ql3AjPsm5Xbt/H7XRvaRU3sRgK8CuJJHNfLourRE= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40TIQUbA014712 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Jan 2024 12:26:30 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 29 Jan 2024 12:26:30 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 29 Jan 2024 12:26:30 -0600 Received: from [10.24.68.115] (ti.dhcp.ti.com [10.24.68.115] (may be forged)) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40TIQOwF067050; Mon, 29 Jan 2024 12:26:24 -0600 Message-ID: <2146baaa-c66e-4e08-b97d-b6cc1791ccaf@ti.com> Date: Mon, 29 Jan 2024 23:56:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments Content-Language: en-US To: Andrew Davis , Hari Nagalla , Lukasz Majewski , Sean Anderson , Jaehoon Chung , Neha Malcom Francis , Simon Glass , Kamlesh Gurudasani , Dasnavis Sabiya , Manorit Chawdhry , Aradhya Bhatia , Bryan Brattlof , Christian Gmeiner , Nishanth Menon , Heinrich Schuchardt , Marcel Ziswiler , Roger Quadros , Jayesh Choudhary , Ralph Siemsen , Marek Vasut , Rasmus Villemoes , , Sinthu Raja M , Udit Kumar References: <20240119175043.3904751-1-a-nandan@ti.com> <20240119175043.3904751-16-a-nandan@ti.com> <1e5c60a4-0200-4207-8485-c3fb26d87f3e@ti.com> <9d81618b-26e8-498e-8866-f03e3e0697e5@ti.com> From: Apurva Nandan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 23/01/24 20:31, Andrew Davis wrote: > On 1/23/24 8:39 AM, Apurva Nandan wrote: >> Hi Andrew, >> >> On 20/01/24 00:43, Andrew Davis wrote: >>> On 1/19/24 11:50 AM, Apurva Nandan wrote: >>>> From: Dasnavis Sabiya >>>> >>>> Add config fragments for am69_sk A72 and R5 configuration. >>>> >>>> This applies on to: >>>> j784s4_evm_a72_defconfig -> am69_sk_a72.config >>>> j784s4_evm_r5_defconfig -> am69_sk_r5.config >>>> >>>> The usage model (with the fragment) would be: >>>> make j784s4_evm_a72_defconfig am69_sk_a72.config >>>> make >>>> >>>> OR >>>> >>>> make j784s4_evm_r5_defconfig am69_sk_r5.config >>>> make >>>> >>>> Signed-off-by: Dasnavis Sabiya >>>> Signed-off-by: Apurva Nandan >>>> --- >>>>   board/ti/j784s4/MAINTAINERS | 2 ++ >>>>   configs/am69_sk_a72.config  | 5 +++++ >>>>   configs/am69_sk_r5.config   | 5 +++++ >>>>   3 files changed, 12 insertions(+) >>>>   create mode 100644 configs/am69_sk_a72.config >>>>   create mode 100644 configs/am69_sk_r5.config >>>> >>>> diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS >>>> index 4433ead66b..69be13f533 100644 >>>> --- a/board/ti/j784s4/MAINTAINERS >>>> +++ b/board/ti/j784s4/MAINTAINERS >>>> @@ -20,3 +20,5 @@ AM69 SK BOARD >>>>   F:    arch/arm/dts/k3-am69-sk.dts >>>>   F:    arch/arm/dts/k3-am69-sk-u-boot.dtsi >>>>   F:    arch/arm/dts/k3-am69-r5-sk.dts >>>> +F:    configs/am69_sk_r5.config >>>> +F:    configs/am69_sk_a72.config >>>> diff --git a/configs/am69_sk_a72.config b/configs/am69_sk_a72.config >>>> new file mode 100644 >>>> index 0000000000..03e74a8a56 >>>> --- /dev/null >>>> +++ b/configs/am69_sk_a72.config >>> >>> Just going to ignore the comments on v7 about putting this >>> in board/ti/..? >>> >> >> Sorry, somehow this got missed. Thanks for bringing up. >> >> >>> Anyway, we can now do includes in defconfigs, so no config >>> fragments needed, you can just add `configs/am69_evm_a72_defconfig` >>> with the content: >>> >>> ``` >>> #include >>> >>> CONFIG_ARM=y >>> CONFIG_ARCH_K3=y >>> CONFIG_SOC_K3_J784S4=y >>> CONFIG_TARGET_J784S4_A72_EVM=y >>> >>> CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk" >>> CONFIG_SPL_OF_LIST="k3-am69-sk" >>> CONFIG_OF_LIST="k3-am69-sk" >>> ``` >>> >>> (note we need to duplicate the _ARM/_TARGET currently to >>> not confuse buildman which seems to directly parse the configs >>> for arch detection). >>> >> >> I tried it, but I don't think this works as '#' signifies a comment >> in defconfig, isn't that true? >> > > The ability to do this was just added recently, try it again :) > > Andrew > Actually, I tried on the latest uboot next, but I still don't see things being included from j784s4_evm_a72_defconfig Can you point to the commit where this was introduced? >> >>> Andrew >>> >>>> @@ -0,0 +1,5 @@ >>>> +# Defconfig fragment to apply on top of j784s4_evm_a72_defconfig >>>> + >>>> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk" >>>> +CONFIG_SPL_OF_LIST="k3-am69-sk" >>>> +CONFIG_OF_LIST="k3-am69-sk" >>>> diff --git a/configs/am69_sk_r5.config b/configs/am69_sk_r5.config >>>> new file mode 100644 >>>> index 0000000000..c42b6f3380 >>>> --- /dev/null >>>> +++ b/configs/am69_sk_r5.config >>>> @@ -0,0 +1,5 @@ >>>> +# Defconfig fragment to apply on top of j784s4_evm_r5_defconfig >>>> + >>>> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk" >>>> +CONFIG_SPL_OF_LIST="k3-am69-r5-sk" >>>> +CONFIG_OF_LIST="k3-am69-r5-sk" >> -- Regards, Apurva Nandan, Texas Instruments.