From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2307DC433F5 for ; Mon, 27 Sep 2021 14:45:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B79F860F11 for ; Mon, 27 Sep 2021 14:45:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B79F860F11 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 58E74822D7; Mon, 27 Sep 2021 16:45:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632753915; bh=dLYSEZeGhBYzlXrybTS2TMPSZUfRTTmpyCJXkvm5jz4=; h=Cc:To:Subject:From:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=APzx7Qsx4ivUegTERewNDZrOrkti3PKE0icPAyEcVruqCW0F3+NX5rlwYkQV9ks07 Iw6T0WMhWL5dgV7VhnTZjxw+SxutjZj7mI10xwqFnj2+n8iLJKmq0DKRTWQanz59zu Uvs40T8MaruV44wfyUuDqi2pCVcO+tgtM+g8FV69WlPjAHiRyTj4QHTIUSGRzZMJhJ Ui7jytSDlhDYGLwkrjYA1Ii5EBMows904z/zQ+BN5/mXnZ05t/bC818vUKsKybVFPG Ov1PFZUCVrRpZ5nLwAjEB2ZW99D7I4ojpmvYOYMSrCfGj8Ns0pMV4V2vT370X0jpHr RIMWLwWGTZBIQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BBFA381D1F for ; Mon, 27 Sep 2021 16:45:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632753911; bh=dLYSEZeGhBYzlXrybTS2TMPSZUfRTTmpyCJXkvm5jz4=; h=Cc:To:Subject:From:Date:From; b=ge13p66Me09dgQzyjnyZkuhS3yo7HLzJKVx/YHNQKrAoOnXYnBU3OR3aPR6N8V59U QBs4pW8El2GN9Q/zV+zlxYhSyPZvjIQ/qx2t8FTCl8ibHHvyOphSQXDzHUYGe+ddig CJEmXPEiadDORSO3JqZ3NlOypOZm5R+0zvj9oQn+KgL/MXhmEaDRXReEwjlEksp434 6cAX5dLx2P1oYFbxV+TQ/W6gnbZ/fZawUx7b5VFzdK87uTvyv/++AHU+d7Fs4CtERN jC9EZ7G1wM9OprXw5VYmqBUrrX840dRaPuzWjtuJuoDfmwLGws8Yqu0JWZ44cJ7gHW YG+SbRqs6AOaw== Received: by janitor.denx.de (Postfix, from userid 108) id 6DBB2A0237; Mon, 27 Sep 2021 16:45:11 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id CBB8DA005A; Mon, 27 Sep 2021 16:45:01 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 9B7181E0F1B; Mon, 27 Sep 2021 16:45:01 +0200 (CEST) Cc: u-boot@lists.denx.de To: Adam Ford , Tom Rini Subject: Bug in board/logicpd/omap3som/omap3logic.h ??? From: Wolfgang Denk MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit Date: Mon, 27 Sep 2021 16:45:01 +0200 Message-ID: <2186934.1632753901@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Adam, commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for SOM-LV Boards" added (among other things) these lines: ... 243 MUX_VAL(CP(MCSPI2_SOMI), (IEN | PTD | DIS | M0)); /*HSUSB2_DATA5*/ 244 MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN | M0)); /*HSUSB2_DATA6*/ 245 MUX_VAL(CP(MCSPI2_CLK), (IEN | PTD | DIS | M0)); /*HSUSB2_DATA7*/ 246 MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ 247 MUX_VAL(CP(ETK_D10_ES2), (IDIS | PTU | DIS | M3)); /*HSUSB2_CLK*/ 248 MUX_VAL(CP(ETK_D11_ES2), (IDIS | PTU | DIS | M3)); /*HSUSB2_STP*/ 249 MUX_VAL(CP(ETK_D12_ES2), (IEN | PTU | DIS | M3)); /*HSUSB2_DIR*/ ... All the entries in set_muxconf_regs() have a terminating semicolon - all except the entry in line # 246. I reckon this is a mistake and should be fixed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I am more bored than you could ever possibly be. Go back to work.