* [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig
@ 2017-03-17 19:41 Philipp Tomsich
2017-03-17 19:41 ` [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together Philipp Tomsich
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Philipp Tomsich @ 2017-03-17 19:41 UTC (permalink / raw)
To: u-boot
The config options for pinctrl on the RK3188, RK3288, RK3328 and
RK3399 previously showed up in menuconfig with the generic string
descriptor "Rockchip pin control driver" requiring one to look through
the help/full description to identify which chip each menu entry was
for.
This change renames each option with the chip-name in the description
string to make it easy to identify the configuration options in
menuconfig.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/pinctrl/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index afdc252..6181ec6 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -133,7 +133,7 @@ config ROCKCHIP_RK3036_PINCTRL
function.
config ROCKCHIP_RK3188_PINCTRL
- bool "Rockchip pin control driver"
+ bool "Rockchip rk3188 pin control driver"
depends on DM
help
Support pin multiplexing control on Rockchip rk3188 SoCs. The driver
@@ -142,7 +142,7 @@ config ROCKCHIP_RK3188_PINCTRL
function.
config ROCKCHIP_RK3288_PINCTRL
- bool "Rockchip pin control driver"
+ bool "Rockchip rk3288 pin control driver"
depends on DM
help
Support pin multiplexing control on Rockchip rk3288 SoCs. The driver
@@ -158,7 +158,7 @@ config PINCTRL_AT91PIO4
controller which is available on SAMA5D2 SoC.
config ROCKCHIP_RK3328_PINCTRL
- bool "Rockchip pin control driver"
+ bool "Rockchip rk3328 pin control driver"
depends on DM
help
Support pin multiplexing control on Rockchip rk3328 SoCs. The driver
@@ -167,7 +167,7 @@ config ROCKCHIP_RK3328_PINCTRL
function.
config ROCKCHIP_RK3399_PINCTRL
- bool "Rockchip pin control driver"
+ bool "Rockchip rk3399 pin control driver"
depends on DM
help
Support pin multiplexing control on Rockchip rk3399 SoCs. The driver
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together
2017-03-17 19:41 [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Philipp Tomsich
@ 2017-03-17 19:41 ` Philipp Tomsich
2017-03-18 11:44 ` Heiko Stuebner
2017-03-18 11:43 ` [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Heiko Stuebner
2017-03-22 13:05 ` Simon Glass
2 siblings, 1 reply; 6+ messages in thread
From: Philipp Tomsich @ 2017-03-17 19:41 UTC (permalink / raw)
To: u-boot
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/pinctrl/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6181ec6..8308686 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -150,13 +150,6 @@ config ROCKCHIP_RK3288_PINCTRL
definitions and pin control functions for each available multiplex
function.
-config PINCTRL_AT91PIO4
- bool "AT91 PIO4 pinctrl driver"
- depends on DM
- help
- This option is to enable the AT91 pinctrl driver for AT91 PIO4
- controller which is available on SAMA5D2 SoC.
-
config ROCKCHIP_RK3328_PINCTRL
bool "Rockchip rk3328 pin control driver"
depends on DM
@@ -175,6 +168,13 @@ config ROCKCHIP_RK3399_PINCTRL
definitions and pin control functions for each available multiplex
function.
+config PINCTRL_AT91PIO4
+ bool "AT91 PIO4 pinctrl driver"
+ depends on DM
+ help
+ This option is to enable the AT91 pinctrl driver for AT91 PIO4
+ controller which is available on SAMA5D2 SoC.
+
config PINCTRL_SANDBOX
bool "Sandbox pinctrl driver"
depends on SANDBOX
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig
2017-03-17 19:41 [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Philipp Tomsich
2017-03-17 19:41 ` [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together Philipp Tomsich
@ 2017-03-18 11:43 ` Heiko Stuebner
2017-03-22 13:05 ` Simon Glass
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2017-03-18 11:43 UTC (permalink / raw)
To: u-boot
Am Freitag, 17. März 2017, 20:41:03 CET schrieb Philipp Tomsich:
> The config options for pinctrl on the RK3188, RK3288, RK3328 and
> RK3399 previously showed up in menuconfig with the generic string
> descriptor "Rockchip pin control driver" requiring one to look through
> the help/full description to identify which chip each menu entry was
> for.
>
> This change renames each option with the chip-name in the description
> string to make it easy to identify the configuration options in
> menuconfig.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
the joys of copy'n'paste and premade defconfigs :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
>
> drivers/pinctrl/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index afdc252..6181ec6 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -133,7 +133,7 @@ config ROCKCHIP_RK3036_PINCTRL
> function.
>
> config ROCKCHIP_RK3188_PINCTRL
> - bool "Rockchip pin control driver"
> + bool "Rockchip rk3188 pin control driver"
> depends on DM
> help
> Support pin multiplexing control on Rockchip rk3188 SoCs. The driver
> @@ -142,7 +142,7 @@ config ROCKCHIP_RK3188_PINCTRL
> function.
>
> config ROCKCHIP_RK3288_PINCTRL
> - bool "Rockchip pin control driver"
> + bool "Rockchip rk3288 pin control driver"
> depends on DM
> help
> Support pin multiplexing control on Rockchip rk3288 SoCs. The driver
> @@ -158,7 +158,7 @@ config PINCTRL_AT91PIO4
> controller which is available on SAMA5D2 SoC.
>
> config ROCKCHIP_RK3328_PINCTRL
> - bool "Rockchip pin control driver"
> + bool "Rockchip rk3328 pin control driver"
> depends on DM
> help
> Support pin multiplexing control on Rockchip rk3328 SoCs. The driver
> @@ -167,7 +167,7 @@ config ROCKCHIP_RK3328_PINCTRL
> function.
>
> config ROCKCHIP_RK3399_PINCTRL
> - bool "Rockchip pin control driver"
> + bool "Rockchip rk3399 pin control driver"
> depends on DM
> help
> Support pin multiplexing control on Rockchip rk3399 SoCs. The driver
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together
2017-03-17 19:41 ` [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together Philipp Tomsich
@ 2017-03-18 11:44 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2017-03-18 11:44 UTC (permalink / raw)
To: u-boot
Am Freitag, 17. März 2017, 20:41:04 CET schrieb Philipp Tomsich:
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
> drivers/pinctrl/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 6181ec6..8308686 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -150,13 +150,6 @@ config ROCKCHIP_RK3288_PINCTRL
> definitions and pin control functions for each available multiplex
> function.
>
> -config PINCTRL_AT91PIO4
> - bool "AT91 PIO4 pinctrl driver"
> - depends on DM
> - help
> - This option is to enable the AT91 pinctrl driver for AT91 PIO4
> - controller which is available on SAMA5D2 SoC.
> -
> config ROCKCHIP_RK3328_PINCTRL
> bool "Rockchip rk3328 pin control driver"
> depends on DM
> @@ -175,6 +168,13 @@ config ROCKCHIP_RK3399_PINCTRL
> definitions and pin control functions for each available multiplex
> function.
>
> +config PINCTRL_AT91PIO4
> + bool "AT91 PIO4 pinctrl driver"
> + depends on DM
> + help
> + This option is to enable the AT91 pinctrl driver for AT91 PIO4
> + controller which is available on SAMA5D2 SoC.
> +
> config PINCTRL_SANDBOX
> bool "Sandbox pinctrl driver"
> depends on SANDBOX
wouldn't it be nicer to try to get an alphabetical ordering going?
That would also prevent future clutter.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig
2017-03-17 19:41 [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Philipp Tomsich
2017-03-17 19:41 ` [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together Philipp Tomsich
2017-03-18 11:43 ` [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Heiko Stuebner
@ 2017-03-22 13:05 ` Simon Glass
2017-03-26 2:42 ` Simon Glass
2 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2017-03-22 13:05 UTC (permalink / raw)
To: u-boot
On 17 March 2017 at 13:41, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> The config options for pinctrl on the RK3188, RK3288, RK3328 and
> RK3399 previously showed up in menuconfig with the generic string
> descriptor "Rockchip pin control driver" requiring one to look through
> the help/full description to identify which chip each menu entry was
> for.
>
> This change renames each option with the chip-name in the description
> string to make it easy to identify the configuration options in
> menuconfig.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> drivers/pinctrl/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig
2017-03-22 13:05 ` Simon Glass
@ 2017-03-26 2:42 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2017-03-26 2:42 UTC (permalink / raw)
To: u-boot
On 22 March 2017 at 07:05, Simon Glass <sjg@chromium.org> wrote:
> On 17 March 2017 at 13:41, Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>> The config options for pinctrl on the RK3188, RK3288, RK3328 and
>> RK3399 previously showed up in menuconfig with the generic string
>> descriptor "Rockchip pin control driver" requiring one to look through
>> the help/full description to identify which chip each menu entry was
>> for.
>>
>> This change renames each option with the chip-name in the description
>> string to make it easy to identify the configuration options in
>> menuconfig.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>> drivers/pinctrl/Kconfig | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-26 2:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-17 19:41 [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Philipp Tomsich
2017-03-17 19:41 ` [U-Boot] [PATCH 2/2] pinctrl: Kconfig: reorder to keep Rockchip options together Philipp Tomsich
2017-03-18 11:44 ` Heiko Stuebner
2017-03-18 11:43 ` [U-Boot] [PATCH 1/2] rockchip: pinctrl: use per-SoC option names for Kconfig Heiko Stuebner
2017-03-22 13:05 ` Simon Glass
2017-03-26 2:42 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox