From: Dragan Simic <dsimic@manjaro.org>
To: Paul Kocialkowski <paulk@sys-base.io>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Jonas Karlman <jonas@kwiboo.se>,
Chris Morgan <macromorgan@hotmail.com>,
Tim Lunn <tim@feathertop.org>,
Paul Kocialkowski <contact@paulk.fr>
Subject: Re: [PATCH 4/4] rockchip: Disable DRAM debug by default
Date: Thu, 26 Sep 2024 22:17:00 +0200 [thread overview]
Message-ID: <21bf0494f4dd9052801c2bacfe014651@manjaro.org> (raw)
In-Reply-To: <20240926183111.1324284-4-paulk@sys-base.io>
Hello Paul,
On 2024-09-26 20:31, Paul Kocialkowski wrote:
> From: Paul Kocialkowski <contact@paulk.fr>
>
> Printing debug details about DRAM is not useful in regular use and
> adds visual pollution to the log. Disable it by default.
With all the respect, I disagree with disabling this by default.
This prints just a couple of lines that can actually be very helpful
when figuring out what's going on in case of some DRAM-related issues
on random devices in the field.
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> configs/anbernic-rgxx3-rk3566_defconfig | 1 -
> configs/neu2-io-rv1126_defconfig | 1 -
> configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
> configs/roc-pc-rk3399_defconfig | 1 -
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock-pi-n8-rk3288_defconfig | 1 -
> configs/sonoff-ihost-rv1126_defconfig | 1 -
> drivers/ram/rockchip/Kconfig | 1 -
> 8 files changed, 8 deletions(-)
>
> diff --git a/configs/anbernic-rgxx3-rk3566_defconfig
> b/configs/anbernic-rgxx3-rk3566_defconfig
> index a03509bf4671..5c074cffeb44 100644
> --- a/configs/anbernic-rgxx3-rk3566_defconfig
> +++ b/configs/anbernic-rgxx3-rk3566_defconfig
> @@ -67,7 +67,6 @@ CONFIG_SPL_DM_REGULATOR_FIXED=y
> CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> CONFIG_SPL_RAM=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> # CONFIG_RNG_SMCCC_TRNG is not set
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> diff --git a/configs/neu2-io-rv1126_defconfig
> b/configs/neu2-io-rv1126_defconfig
> index 2a4c9b45a04f..84e4465f2c5f 100644
> --- a/configs/neu2-io-rv1126_defconfig
> +++ b/configs/neu2-io-rv1126_defconfig
> @@ -45,7 +45,6 @@ CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_REGULATOR_PWM=y
> CONFIG_PWM_ROCKCHIP=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYSRESET=y
> diff --git a/configs/roc-pc-mezzanine-rk3399_defconfig
> b/configs/roc-pc-mezzanine-rk3399_defconfig
> index a57899bfdfa0..b4041902b381 100644
> --- a/configs/roc-pc-mezzanine-rk3399_defconfig
> +++ b/configs/roc-pc-mezzanine-rk3399_defconfig
> @@ -65,7 +65,6 @@ CONFIG_REGULATOR_PWM=y
> CONFIG_SPL_DM_REGULATOR_FIXED=y
> CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_RAM_ROCKCHIP_LPDDR4=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> diff --git a/configs/roc-pc-rk3399_defconfig
> b/configs/roc-pc-rk3399_defconfig
> index b45f0e0a8994..922f67320c20 100644
> --- a/configs/roc-pc-rk3399_defconfig
> +++ b/configs/roc-pc-rk3399_defconfig
> @@ -62,7 +62,6 @@ CONFIG_REGULATOR_PWM=y
> CONFIG_SPL_DM_REGULATOR_FIXED=y
> CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_RAM_ROCKCHIP_LPDDR4=y
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> diff --git a/configs/rock-pi-n10-rk3399pro_defconfig
> b/configs/rock-pi-n10-rk3399pro_defconfig
> index ec995a54a0ee..17fe939ec989 100644
> --- a/configs/rock-pi-n10-rk3399pro_defconfig
> +++ b/configs/rock-pi-n10-rk3399pro_defconfig
> @@ -51,7 +51,6 @@ CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_PMIC_RK8XX=y
> CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> diff --git a/configs/rock-pi-n8-rk3288_defconfig
> b/configs/rock-pi-n8-rk3288_defconfig
> index 4c09b9137ef8..af0fa8879421 100644
> --- a/configs/rock-pi-n8-rk3288_defconfig
> +++ b/configs/rock-pi-n8-rk3288_defconfig
> @@ -73,7 +73,6 @@ CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> CONFIG_RAM=y
> CONFIG_SPL_RAM=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> diff --git a/configs/sonoff-ihost-rv1126_defconfig
> b/configs/sonoff-ihost-rv1126_defconfig
> index 4890644c7e6f..739adb49ce93 100644
> --- a/configs/sonoff-ihost-rv1126_defconfig
> +++ b/configs/sonoff-ihost-rv1126_defconfig
> @@ -46,7 +46,6 @@ CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_REGULATOR_PWM=y
> CONFIG_PWM_ROCKCHIP=y
> -# CONFIG_RAM_ROCKCHIP_DEBUG is not set
> CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYSRESET=y
> diff --git a/drivers/ram/rockchip/Kconfig
> b/drivers/ram/rockchip/Kconfig
> index 67c63ecba047..e030c982eccb 100644
> --- a/drivers/ram/rockchip/Kconfig
> +++ b/drivers/ram/rockchip/Kconfig
> @@ -15,7 +15,6 @@ if RAM_ROCKCHIP
>
> config RAM_ROCKCHIP_DEBUG
> bool "Rockchip ram drivers debugging"
> - default y
> help
> This enables debugging ram driver API's for the platforms
> based on Rockchip SoCs.
next prev parent reply other threads:[~2024-09-26 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 18:31 [PATCH 1/4] rockchip: rk3399-roc-pc: Hook sysreset gpio to enable full reset Paul Kocialkowski
2024-09-26 18:31 ` [PATCH 2/4] rockchip: rk3399-rockpro64: " Paul Kocialkowski
2024-09-27 9:28 ` Quentin Schulz
2024-11-05 15:38 ` Quentin Schulz
2024-11-05 18:46 ` Paul Kocialkowski
2024-09-26 18:31 ` [PATCH 3/4] rockchip: rk3399-rockpro64: Disable bootstage instrumentation config Paul Kocialkowski
2024-09-30 9:01 ` Peter Robinson
2024-09-30 18:52 ` Simon Glass
2024-09-30 19:07 ` Paul Kocialkowski
2024-10-01 11:19 ` Simon Glass
2024-09-26 18:31 ` [PATCH 4/4] rockchip: Disable DRAM debug by default Paul Kocialkowski
2024-09-26 20:17 ` Dragan Simic [this message]
2024-09-26 20:51 ` Paul Kocialkowski
2024-09-26 21:04 ` Dragan Simic
2024-09-26 21:16 ` Paul Kocialkowski
2024-09-26 21:24 ` Dragan Simic
2024-09-26 21:39 ` Paul Kocialkowski
2024-09-26 21:50 ` Dragan Simic
2024-09-27 9:25 ` [PATCH 1/4] rockchip: rk3399-roc-pc: Hook sysreset gpio to enable full reset Quentin Schulz
2024-09-27 9:53 ` Paul Kocialkowski
2024-09-27 10:07 ` Quentin Schulz
2024-09-27 12:25 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bf0494f4dd9052801c2bacfe014651@manjaro.org \
--to=dsimic@manjaro.org \
--cc=contact@paulk.fr \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=macromorgan@hotmail.com \
--cc=paulk@sys-base.io \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=tim@feathertop.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox