From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B195C36010 for ; Tue, 8 Apr 2025 03:23:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6093C83314; Tue, 8 Apr 2025 05:22:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.b="Zd/BdU87"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8543A83334; Tue, 8 Apr 2025 05:22:30 +0200 (CEST) Received: from mail-m19731118.qiye.163.com (mail-m19731118.qiye.163.com [220.197.31.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACB2C8332E for ; Tue, 8 Apr 2025 05:22:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.67] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 1102089f6; Tue, 8 Apr 2025 11:22:23 +0800 (GMT+08:00) Message-ID: <21ca35af-0d79-4ebc-987e-b2522ffa4e10@rock-chips.com> Date: Tue, 8 Apr 2025 11:22:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/30] arm64: dts: rockchip: Add maskrom button to Radxa E20C To: Jonas Karlman , Simon Glass , Philipp Tomsich , Tom Rini , Sumit Garg Cc: Yao Zi , Chukun Pan , u-boot@lists.denx.de, Heiko Stuebner References: <20250407224743.2423921-1-jonas@kwiboo.se> <20250407224743.2423921-13-jonas@kwiboo.se> Content-Language: en-US From: Kever Yang In-Reply-To: <20250407224743.2423921-13-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGR8eTVZPGUJDHxkfSEIZTh1WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a96136ba35d03afkunm1102089f6 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NRw6Pww*TzJNPUIdARU6Tgs# PikwCwFVSlVKTE9PS0NJTk9PQ05JVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFITUhINwY+ DKIM-Signature: a=rsa-sha256; b=Zd/BdU87vVJEUX2NBccXqf+YIMXUt+GMgwNiine9o8eIeQUaLO3b1bhCHHQJ4gXGT4kHGE7nwSFJuxmYUDM5fuCAh3Uvzt+HxpoIqo93lbtfC2su4j0EWMOhcvFDGqIyPkchO5BxS/dflFx5KUH+kpKcBa73gSYWu0Uw6eYS9Pg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=CuXtWqBY/IzUQU2RSB4j++2xbVSvo70Tpjo0jpqVr6c=; h=date:mime-version:subject:message-id:from; X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2025/4/8 06:46, Jonas Karlman wrote: > Radxa E20C has two buttons, one SARADC maskrom button and one GPIO user > button. > > Add support for the maskrom button using a adc-keys node, also add the > regulators used by SARADC controller. > > Signed-off-by: Jonas Karlman > Link: https://lore.kernel.org/r/20250304201642.831218-5-jonas@kwiboo.se > Signed-off-by: Heiko Stuebner > > [ upstream commit: 3a2819ee9c71d1c6388e456cc4eb042914d15d7e ] > > (cherry picked from commit 460ef5b623e5fa69843305faf50f6b1a8e81e1cd) > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > .../src/arm64/rockchip/rk3528-radxa-e20c.dts | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/dts/upstream/src/arm64/rockchip/rk3528-radxa-e20c.dts b/dts/upstream/src/arm64/rockchip/rk3528-radxa-e20c.dts > index b378774d2a4e..5346ef457c2a 100644 > --- a/dts/upstream/src/arm64/rockchip/rk3528-radxa-e20c.dts > +++ b/dts/upstream/src/arm64/rockchip/rk3528-radxa-e20c.dts > @@ -19,6 +19,20 @@ > stdout-path = "serial0:1500000n8"; > }; > > + adc-keys { > + compatible = "adc-keys"; > + io-channels = <&saradc 0>; > + io-channel-names = "buttons"; > + keyup-threshold-microvolt = <1800000>; > + poll-interval = <100>; > + > + button-maskrom { > + label = "MASKROM"; > + linux,code = ; > + press-threshold-microvolt = <0>; > + }; > + }; > + > gpio-keys { > compatible = "gpio-keys"; > pinctrl-names = "default"; > @@ -61,6 +75,35 @@ > linux,default-trigger = "netdev"; > }; > }; > + > + vcc_1v8: regulator-1v8-vcc { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_1v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_3v3>; > + }; > + > + vcc_3v3: regulator-3v3-vcc { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_3v3"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc5v0_sys>; > + }; > + > + vcc5v0_sys: regulator-5v0-vcc-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > }; > > &pinctrl { > @@ -85,6 +128,11 @@ > }; > }; > > +&saradc { > + vref-supply = <&vcc_1v8>; > + status = "okay"; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0m0_xfer>;