public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport
Date: Wed, 24 Jul 2013 19:52:20 +0200	[thread overview]
Message-ID: <2212981.62UMKmQoca@ax5200p> (raw)
In-Reply-To: <51EEA3FA.2010804@wwwdotorg.org>

On Tuesday 23 July 2013 08:40:42 Stephen Warren wrote:
> On 07/22/2013 01:09 AM, Marc Dietrich wrote:

[ snip the stuff we agreed upon ]

> > The nvec still needs to tell the slave driver which protocol to use, but
> > that can be hard coded.
> 
> I'm not sure what that means. At the controller/HW level, aren't I2C and
> SMBUS the same; it's just the data within the transactions that may be
> more defined by one or the other?

at this level yes, but we need to handle the underlying protocol in the ISR, 
which means that depending on the protocol (smbus or I2C), we need a different 
interrupt service routine. Currently we are doing most of the smbus protocol 
in the ISR because of timing reasons and I'm not sure if we can change this. 
We are already suffering from nvec timeouts and I fear that splitting the 
protocol out of the ISR would make things even worse.

I'm going to submit a new DT binding during the weekend. Meanwhile, Andrey is 
trying to split the uboot driver in the hw and nvec parts and also adapting it 
for the new binding.

Marc

  reply	other threads:[~2013-07-24 17:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  8:47 [U-Boot] [PATCH 0/3] ARM: tegra: add nvec keyboard support for paz00 Andrey Danin
2013-07-19  8:47 ` [U-Boot] [PATCH 1/3] ARM: tegra: add nvec driver Andrey Danin
2013-07-19 16:28   ` Tom Warren
2013-07-19  8:47 ` [U-Boot] [PATCH 2/3] ARM: tegra: add input driver for nvec keyboard Andrey Danin
2013-07-19  8:47 ` [U-Boot] [PATCH 3/3] ARM: tegra: paz00: enable nvec keyboard support Andrey Danin
2013-07-19 19:14   ` [U-Boot] [Ac100] " Stephen Warren
2013-07-20  9:12     ` [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboard support Marc Dietrich
2013-07-21  3:20       ` Stephen Warren
2013-07-22  8:09         ` [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport Marc Dietrich
2013-07-23 15:40           ` Stephen Warren
2013-07-24 17:52             ` Marc Dietrich [this message]
2013-07-25 17:40               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2212981.62UMKmQoca@ax5200p \
    --to=marvin24@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox