From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Williams Date: Tue, 5 Nov 2019 02:13:13 +0000 Subject: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support In-Reply-To: <20191104172216.GA11173@bill-the-cat> References: <54252238.uJ5nVSEdrx@flash> <20191104172216.GA11173@bill-the-cat> Message-ID: <2235710.XZ1BuITEuP@flash> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Monday, November 4, 2019 9:22:16 AM PST Tom Rini wrote: > On Thu, Oct 31, 2019 at 06:01:34PM +0000, Aaron Williams wrote: > > Hi Wolfgang, > > > > On Thursday, October 31, 2019 3:40:27 AM PDT Wolfgang Denk wrote: > > > Dear Aaron, > > > > > > In message <1889679.7FQr5zsBR1@flash> you wrote: > > > > Currently we are using 39MB under arch/mips. I think I can easily cut > > > > this > > > > down to 15MB or smaller, especially by moving some code here to the > > > > appropriate driver directories (i.e. DRAM, pcie, watchdog, etc.) > > > > > > > > It will still be a large SoC, though. > > > > > > Have you already looked at formal requirements, like coding style > > > etc.? Did you ever run your additions through checkpatch.pl, for > > > example? > > > > We did follow the formal coding style. Everything will go through > > checkpatch. My biggest complaint about it is the 80 columns for debug and > > other print statements. > > checkpatch doesn't complain about those when they use standard logging > functions, however. It complains plenty about printf(), debug() and a number of other standard U- Boot logging calls. Regards, Aaron