From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CC1C433EF for ; Mon, 27 Sep 2021 15:51:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7558860F94 for ; Mon, 27 Sep 2021 15:51:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7558860F94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A8DA812B6; Mon, 27 Sep 2021 17:51:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632757865; bh=GZAz/xu2zGYvDCGtPDj/gWDBSzHeRfBXsRZr3zolhWw=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wYBFtbq81YIBdEqfl5h+3PF3Imr0P0gxiosoa6Zd/lrtiOl3mKHm2oQgJYvihWuej uWPSCU5scx6tyAY0uN1SIpL8mMejlTJm+3j4d/npOAVRCmyPKICdO+piPediBhimIO RcUh4YGs4NlSMoaKInlQmtbfySAqEby0cKRFh+C+Gg0v+HKI6ttcykkah6v9KIq49P 86WOLl1RP8FIrO68gDO8v1UUWjhbPuLhoBArJi0SMudyGIiLxPhw9vmKxOFLeysVqS kEKyJgPaKytTx+D+3J5ePdw7oGQBBlxM5siSQbg2Pn0Q6KV4m4wxnYDTKl7MGE9Yo0 B18gPfxbMawmQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6BD63827C5 for ; Mon, 27 Sep 2021 17:51:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632757862; bh=GZAz/xu2zGYvDCGtPDj/gWDBSzHeRfBXsRZr3zolhWw=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=0KL/HuWwN8Lvij8AYQ4gc9oYhjhkUqHS7ynCNdyzQ4HIbGyaWsVJDNqttPUizGupw rRGgLSSJ2KzZ7mKNo4K3hlF3mB0cDdFwACHoILePqbNsyhRDMpInjEu4D4YGz+dYX1 dfjFdPO7DFe5g4j3pJVfqrZXPoO9kbB1lslVX2Rpv9vn2sT6AM+qc6fa0RGSCfVNvd OP2tbNYuF6YgFDnCElI8P1dZGkV2RNU8oInr0Z6Bcl5wm2/miuk7N76X6MCYA7eUoc 1P00rM1lhfQL9mja2S2Ijt12xBlVJujruPpVnGE0Q+sRoLPTqd2ITqQjPoe0CwejNB fOylp97R2a70w== Received: by janitor.denx.de (Postfix, from userid 108) id BA742A005A; Mon, 27 Sep 2021 17:51:01 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 55F50A014E; Mon, 27 Sep 2021 17:50:55 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 2809C1E0F1B; Mon, 27 Sep 2021 17:50:55 +0200 (CEST) To: Adam Ford cc: Tom Rini , U-Boot Mailing List From: Wolfgang Denk Subject: Re: Bug in board/logicpd/omap3som/omap3logic.h ??? MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <2186934.1632753901@gemini.denx.de> <20210927144938.GK31748@bill-the-cat> Comments: In-reply-to Adam Ford message dated "Mon, 27 Sep 2021 10:12:43 -0500." Date: Mon, 27 Sep 2021 17:50:55 +0200 Message-ID: <2268709.1632757855@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Adam, In message you wrote: > > > > > > commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for > > > SOM-LV Boards" added (among other things) these lines: > > > > > > ... > > > 243 MUX_VAL(CP(MCSPI2_SOMI), (IEN | PTD | DIS | M0)); /*HSUSB2_DATA5*/ > > > 244 MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN | M0)); /*HSUSB2_DATA6*/ > > > 245 MUX_VAL(CP(MCSPI2_CLK), (IEN | PTD | DIS | M0)); /*HSUSB2_DATA7*/ > > > 246 MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ > > > 247 MUX_VAL(CP(ETK_D10_ES2), (IDIS | PTU | DIS | M3)); /*HSUSB2_CLK*/ > > > 248 MUX_VAL(CP(ETK_D11_ES2), (IDIS | PTU | DIS | M3)); /*HSUSB2_STP*/ > > > 249 MUX_VAL(CP(ETK_D12_ES2), (IEN | PTU | DIS | M3)); /*HSUSB2_DIR*/ > > > ... > > > > > > All the entries in set_muxconf_regs() have a terminating semicolon - > > > all except the entry in line # 246. > > > > > > I reckon this is a mistake and should be fixed? > > > > Interesting. MUX_VAL is from arch/arm/include/asm/arch-omap3/mux.h and > > includes a semicolon, so that's how this didn't trip anything up. Most > > of the time it's not used with one either, from a quick grep. > > I am guessing it was left out by accident. I would not have > intentionally done that. I can submit a patch to make it consistent > if you want. Yes, it should be made xonsistent, please - otherwise everybody seeing this wonders what is going on here. Tom says there is already a semicolon in the macro and most use cases don;t have one, so the fix should probably be to keep that line and remove the other semicolons ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The human race is faced with a cruel choice: work or daytime tele- vision.