From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6051FC433F5 for ; Tue, 28 Sep 2021 06:48:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82C1A61159 for ; Tue, 28 Sep 2021 06:48:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82C1A61159 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E1E6382DA7; Tue, 28 Sep 2021 08:48:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632811701; bh=FJ1kn8Fb3uFMcv4OEHuQh78NpKbqOlrJZuY2MaRQkQA=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XEVxbXPQ9KZLa3yvU8CRZtgk+MrGggsbIwYSNGeazLhslEVbiIIudQSr9ZtLhLnHp NfP5NAve1SAGXc8RoHvWXXcMY4fdptG1gaYyZ568Y765kPP04mNSGybr+TVhPWDXa6 1l+x6VCxgb4d90sefe8mbXe6eP7ekZc/yC87zpmXapf4QyKIyFMhe4ZtboaSrOPjOG vnnK014UAGWZaljPRTaYSDMuTG5xuRq55EJ3us534Pg6ID8ThT7rtAtY8GTDBOvolI ppLpYIAzQhVkOlDeDHHunCTClkUURPIFHVT6emakwe2qtUu2R1zbPmHNVnQWxjGtqI C4t0v6BsQlS8A== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 937FC80C58 for ; Tue, 28 Sep 2021 08:48:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632811698; bh=FJ1kn8Fb3uFMcv4OEHuQh78NpKbqOlrJZuY2MaRQkQA=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=F0NY6/8wVr/xalWsNekmM7hls4nN2H+LpOvhZFZeJ91AFQ18yw7srRd/Z7MdoqbrK aFZJUVdyfbd1yN0fBVw6/Krh2rmNF4QDqH6hYD9AAe5kBAPKZD17Xy3fEY4f6nXyiZ 3CChtK3T6RI39LQAzGLa3xNqyc7LAQOJQjkcxnKqYgqH014s+t4YSmCk5C6sHAPjYE GI66wfhqtli3SSTwKTY/Tc5sBahRXRHy4swGkOopae0lhWubSl6+4y3itZYfotqRT8 yO9+uJC6vJSuAHtq50GULBY+HeO5e+BwVOXp6DZelWd4qeIFdCaMQe3gIAyg/MzqwT VtUh5raOkLTNw== Received: by janitor.denx.de (Postfix, from userid 108) id 4540BA024D; Tue, 28 Sep 2021 08:48:18 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 0DBE2A005A; Tue, 28 Sep 2021 08:48:11 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 9A6721E0F1B; Tue, 28 Sep 2021 08:48:10 +0200 (CEST) To: Adam Ford cc: u-boot@lists.denx.de, trini@konsulko.com, lokeshvutla@ti.com From: Wolfgang Denk Subject: Re: [PATCH] ARM: omap3_logic: Cleanup usage of MUX_VAL MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210927183030.506532-1-aford173@gmail.com> References: <20210927183030.506532-1-aford173@gmail.com> Comments: In-reply-to Adam Ford message dated "Mon, 27 Sep 2021 13:30:30 -0500." Date: Tue, 28 Sep 2021 08:48:10 +0200 Message-ID: <2299718.1632811690@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Adam Ford, In message <20210927183030.506532-1-aford173@gmail.com> you wrote: > The macro called MUX_VAL generates a writel instruction with > semicolon at the end. This table was written to use semicolons, > however one was missed: > > MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ > > Since the extra semicolon is unnecessary with the use of the macro, > remove all of them. Thanks. .... > + MUX_VAL(CP(MCSPI2_SOMI), (IEN | PTD | DIS | M0)) /*HSUSB2_DATA5*/ > + MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN | M0)) /*HSUSB2_DATA6*/ > + MUX_VAL(CP(MCSPI2_CLK), (IEN | PTD | DIS | M0)) /*HSUSB2_DATA7*/ > MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ This line stands out because indentation is different from all the other lines. You might want to fix that, too, while we are at it? Reviewd-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de When a program is being tested, it is too late to make design changes. -- Geoffrey James, "The Tao of Programming"