From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB345C48BE0 for ; Fri, 11 Jun 2021 11:18:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05023608FE for ; Fri, 11 Jun 2021 11:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05023608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 34F70801DE; Fri, 11 Jun 2021 13:18:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="iPCpzSfL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59CC380377; Fri, 11 Jun 2021 13:18:54 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 510F280092 for ; Fri, 11 Jun 2021 13:18:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kristo@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 48B27608FE; Fri, 11 Jun 2021 11:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623410329; bh=siyz418rRWReCFtgcXkXdV6eH8SjGUpLyKEwH1YJ5fs=; h=Subject:To:References:From:Date:In-Reply-To:From; b=iPCpzSfLb6oJ0DbavVAxXjngTGmOwjVBGnXbXPtC9d5KI1mB8rsrIovIuuQIuI1VO iBuv3c5fLyAq2Q5F9iYmHsq26l8YhFU5sSSlZNf3FrPBfMnl9sv8f+Y7dY4gNYt3lz PNM7gdPapSHBeE4IsiTg/9V5Xpd3GBJdtcKNafGTxC/tkgEVhzo5s8yF6y2LEzkZ/N PZ0rBsMyc0R+gqZzQB5BU4W+LVzYUJmtX0hltPcxx1fnTuJ9jxiahN/1gTpi8UA1bF 9tvmfRt282Fy8FpkSOyGMEsE4usIGmdB2m6tGLkDLMvY73U/V4BhlpUUhejFw8Lxlf f3rEWFP975UMg== Subject: Re: [PATCHv6 00/26] HSM rearch series for TI K3 devices To: Lokesh Vutla , trini@konsulko.com, u-boot@lists.denx.de References: <20210611084527.7048-1-kristo@kernel.org> <2a06a7d2-8101-91e9-3813-ce9d4f327d84@ti.com> From: Tero Kristo Message-ID: <22da4ad1-8a11-50fb-7e97-2caa0ee187dc@kernel.org> Date: Fri, 11 Jun 2021 14:18:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2a06a7d2-8101-91e9-3813-ce9d4f327d84@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/06/2021 14:08, Lokesh Vutla wrote: > Hi Tero, > > On 11/06/21 2:15 pm, Tero Kristo wrote: >> Hello, >> >> One more post, this time with the #ifdef hackery converted to use the >> IS_ENABLED / CONFIG_IS_ENABLED macros, and also removed the "common.h" >> include from k3-clk.h header. This version also contains fixes to any >> build issues reported by Lokesh, and these are squashed in to relevant >> patches. > > Can you see if the below warnings can be fixed? > > hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch > ------------------------------------------------------------------- > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #26: FILE: arch/arm/mach-k3/common.c:31: > +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) This is static data, can't be fixed. Unless we want to compile it in always? > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #35: FILE: arch/arm/mach-k3/common.c:40: > +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) Same, static data. > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #55: FILE: arch/arm/mach-k3/common.c:131: > +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) This is actually just an old macro I changed from #ifdef to IS_ENABLED. Fixing the whole file from the existing #ifdef:s should be outside the scope of this series. > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #124: FILE: arch/arm/mach-k3/common.c:264: > +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) This code addresses the static data defined before, changing this will break compilation; unless we compile the data always in. > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #128: FILE: arch/arm/mach-k3/common.c:268: > +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) Same as above. > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #150: FILE: arch/arm/mach-k3/common.c:290: > +#if IS_ENABLED(CONFIG_TI_SECURE_DEVICE) This can't be changed, the code it addresses is only linked in with the config, causing a linker time failure if this is fixed. Imho, I am not too convinced about the checkpatch tool complaining about these issues. :) -Tero > > total: 0 errors, 6 warnings, 0 checks, 144 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch has style > problems, please review. > ------------------------------------------------------------------- > hsm/0019-arm-mach-k3-do-board-config-for-PM-only-if-supported.patch > ------------------------------------------------------------------- > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible > #24: FILE: arch/arm/mach-k3/sysfw-loader.c:162: > +#if !CONFIG_IS_ENABLED(K3_DM_FW) > > total: 0 errors, 1 warnings, 0 checks, 13 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > > Thanks and regards, > Lokesh >