[U-Boot] [PATCH 1/2] mxc nand: Add support for i.MX5

Marek Vasut
2013-01-08T11:05:26Z

Dear Beno?t Th?baudeau,

[...]

> > > > NOTE: I'm seeing issues when this is compiled into U-Boot. U-Boot
> > > > won't boot on
> > > > my MX53 board and will hang right after printing "DRAM:" and
> > > > before
> > > > printing the
> > > > CPU info. I suspect it's some kind of unaligned access.
> > >
> > > OK. I'm waiting for your test results. It works for me on i.MX51
> > > with
> > > 2012.07.
> >
> > It works with 2013.01-rc1, but I have issues. When I boot the board
> > from SD, it
> > hangs. When I load via JTAG, it doesn't hang. I suspect it's
> > something related
> > to the MXC NAND driver, since if the driver is not compiled in, it
> > works like
> > charm both ways.
> >
> > Otherwise, when booted, the NAND works fine.
> >
> > I wonder if there's some unaligned access or something happening in
> > the NAND
> > driver. Or maybe some other issue where the code is miscompiled.
>
> Or there is something wrong with the Flash header or SPL?

Flash header? SPL is not used, I boot from SD.

> > > > NOTE2: I fixed a few complaints from GCC
> > >
> > > Which ones? I don't see any such change in this new version.
> >
> > This one I think:
> >
> > 354 @@ -1167,8 +1226,8 @@ static struct nand_bbt_descr
> > bbt_mirror_descr = {
> > 355 int board_nand_init(struct nand_chip *this)
> > 356 {
> > 357 struct mtd_info *mtd;
> > 358 -#ifdef MXC_NFC_V2_1
> > 359 - uint16_t tmp;
> > 360 +#if defined(MXC_NFC_V2_1) || defined(MXC_NFC_V3_2)
> > 361 + uint32_t tmp;
> > 362 #endif
> > 363
> > 364 #ifdef CONFIG_SYS_NAND_USE_FLASH_BBT
>
> This is just the rebase. Or perhaps you started from
> http://patchwork.ozlabs.org/patch/177098/ instead of
> http://patchwork.ozlabs.org/patch/179176/.

Lemme try the V2, thanks. …