From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Andre Przywara <andre.przywara@arm.com>
Cc: Tom Rini <trini@konsulko.com>,
Cody Eksal <masterr3c0rd@epochal.quest>,
Simon Glass <sjg@chromium.org>,
linux-sunxi@lists.linux.dev, Parthiban <parthiban@linumiz.com>
Subject: Re: [PATCH 2/8] sunxi: pmic_bus: support alternative I2C address
Date: Sat, 18 Jan 2025 08:21:31 +0100 [thread overview]
Message-ID: <2352334.ElGaqSPkdT@jernej-laptop> (raw)
In-Reply-To: <20250117014537.22513-3-andre.przywara@arm.com>
Dne petek, 17. januar 2025 ob 02:45:31 Srednjeevropski standardni čas je Andre Przywara napisal(a):
> Some of the X-Power AXP PMICs can be ordered with an alternative I2C
> address, for instance an AXP717 could be shipped with address 0x34 or
> with address 0x35.
> The datasheets for the AXP717 and AXP803 list two possible addresses,
> and they are always consecutive. For DM (DT) based drivers this is no
> problem, but the Allwinner SPL code relies on a hardcoded address.
>
> Add a Kconfig variable that will add "1" to the existing address if it
> is set.
> This enables to use the AXP717 as used on boards with the new Allwinner
> A523 chip.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
This works until some board vendor start mixing one or another address
PMIC. Note that BSP boot0 does address autodetection, so it's not entirely
out of the question. Anyway, let's hope we don't see anything like that.
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2025-01-18 7:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 1:45 [PATCH 0/8] sunxi: (early) Allwinner A133 SoC support Andre Przywara
2025-01-17 1:45 ` [PATCH 1/8] sunxi: clock: improve grouping of default clock register values Andre Przywara
2025-01-18 7:16 ` Jernej Škrabec
2025-01-17 1:45 ` [PATCH 2/8] sunxi: pmic_bus: support alternative I2C address Andre Przywara
2025-01-18 7:21 ` Jernej Škrabec [this message]
2025-01-19 22:25 ` Andre Przywara
2025-01-20 16:42 ` Jernej Škrabec
2025-01-20 19:21 ` Simon Glass
2025-01-21 0:05 ` Andre Przywara
2025-01-23 14:37 ` Simon Glass
2025-03-18 0:34 ` Andre Przywara
2025-01-17 1:45 ` [PATCH 3/8] sunxi: H616: DRAM: rename Kconfig parameters to be more generic Andre Przywara
2025-01-18 7:22 ` Jernej Škrabec
2025-01-17 1:45 ` [PATCH 4/8] clk: sunxi: Add support for the A100/A133 CCU Andre Przywara
2025-01-18 7:24 ` Jernej Škrabec
2025-01-17 1:45 ` [PATCH 5/8] pinctrl: sunxi: add Allwinner A100/A133 pinctrl description Andre Przywara
2025-01-18 7:25 ` Jernej Škrabec
2025-01-17 1:45 ` [PATCH 6/8] power: pmic: sunxi: add SPL support for the AXP803 Andre Przywara
2025-01-18 7:29 ` Jernej Škrabec
2025-01-17 1:45 ` [PATCH 7/8] sunxi: A133: add DRAM init code [WIP!] Andre Przywara
2025-01-18 8:17 ` Jernej Škrabec
2025-01-18 15:20 ` Cody Eksal
2025-01-17 1:45 ` [PATCH 8/8] sunxi: add support for the Allwinner A100/A133 SoC Andre Przywara
2025-01-18 7:35 ` Jernej Škrabec
2025-01-19 23:52 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2352334.ElGaqSPkdT@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=jh80.chung@samsung.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=lukma@denx.de \
--cc=masterr3c0rd@epochal.quest \
--cc=parthiban@linumiz.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox