public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings
Date: Tue, 15 May 2018 07:15:30 +0200	[thread overview]
Message-ID: <2367168.ssRM2iqVlV@jernej-laptop> (raw)
In-Reply-To: <20180514204953.11606-3-anarsoul@gmail.com>

Hi,

Dne ponedeljek, 14. maj 2018 ob 22:49:53 CEST je Vasily Khoruzhick napisal(a):
> Currently dw_hdmi configures HSYNC polarity using VSYNC setting from
> EDID and vice versa. Fix it, since it breaks displays where HSYNC
> and VSYNC polarity differs
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Best regards,
Jernej

> ---
>  drivers/video/dw_hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/dw_hdmi.c b/drivers/video/dw_hdmi.c
> index dbad0e2b24..229bd63c97 100644
> --- a/drivers/video/dw_hdmi.c
> +++ b/drivers/video/dw_hdmi.c
> @@ -401,11 +401,11 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi,
>  	/* set up hdmi_fc_invidconf */
>  	inv_val = HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE;
> 
> -	inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
> +	inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
>  		   HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH :
>  		   HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW);
> 
> -	inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
> +	inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
>  		   HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH :
>  		   HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW);
> 
> --
> 2.17.0

  reply	other threads:[~2018-05-15  5:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 20:49 [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
2018-05-15  5:15   ` Jernej Škrabec
2018-05-14 20:49 ` [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-15  5:15   ` Jernej Škrabec [this message]
2018-05-15  6:08 ` [U-Boot] [PATCH v2 0/2] " Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2367168.ssRM2iqVlV@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox