public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ron Madrid <ron_madrid@sbcglobal.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
Date: Thu, 16 Oct 2008 14:05:03 -0700 (PDT)	[thread overview]
Message-ID: <2397.55380.qm@web83503.mail.sp1.yahoo.com> (raw)
In-Reply-To: <20081016191740.GA19008@ld0162-tx32.am.freescale.net>

So is there a particular convention for which bytes should be used within the OOB area for an ECC?  I've looked for information on this but haven't been able to come up with anything.


--- On Thu, 10/16/08, Scott Wood <scottwood@freescale.com> wrote:

> From: Scott Wood <scottwood@freescale.com>
> Subject: Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices
> To: "Ron Madrid" <ron_madrid@sbcglobal.net>
> Cc: u-boot at lists.denx.de
> Date: Thursday, October 16, 2008, 12:17 PM
> On Tue, Oct 14, 2008 at 01:24:09PM -0700, Ron Madrid wrote:
> > 1.  I don't see anywhere that the AL (address
> length, or number of
> > address cycles) can be set to anything other than 2. 
> It appears to be
> > hard coded in both files.
> 
> Correct.  AFAICT, setting AL to anything less than 2 is
> just an
> optimization for small flashes.  Linux will make that
> optimization, but
> the way NAND devices are currently probed in u-boot makes
> that awkward
> (no opportunity to run code after size is known, but before
> nand_scan_tail).
> 
> > 2.  nand_boot_fsl_elbc.c uses ECCM = 1 for large page
> devices, but I
> > don't see a place where fsl_elbc_nand.c sets ECCM
> to 1 for similar
> > devices.
> 
> That looks like a bug.
> 
> -Scott

  reply	other threads:[~2008-10-16 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 20:24 [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices Ron Madrid
2008-10-16 19:17 ` Scott Wood
2008-10-16 21:05   ` Ron Madrid [this message]
2008-10-16 21:05     ` Scott Wood
  -- strict thread matches above, loose matches on Subject: below --
2008-10-16 22:06 Ron Madrid
2008-10-16 22:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2397.55380.qm@web83503.mail.sp1.yahoo.com \
    --to=ron_madrid@sbcglobal.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox