public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Casanova <detlev.casanova@collabora.com>
To: u-boot@lists.denx.de
Cc: "Stefan Roese" <sr@denx.de>,
	"Pierre-Clément Tosi" <ptosi@google.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Andrew Scull" <ascull@google.com>
Subject: [BUG] Devices of uclass BLK are not listed on x86
Date: Fri, 17 Mar 2023 17:29:48 -0400	[thread overview]
Message-ID: <2448736.vk3iotpzCV@arisu> (raw)

Hello,

We have been having an issue with IDE and SCSI drives not being usable on the 
x86 architecture.

After bisecting, it looks like commit f2ebaaa9f38dddddefaf2e616a9fc489fe8b4021 
(pci: Handle failed calloc in decode_regions()) is the culprit.

Indeed, it was working when decode_regions() was not returning an error. But 
now that it does, no blk devices get registered anymore.

The decode_regions() function fails because it calls "ofnode_get_property", 
which fails on systems that do not use a device tree

Would it make sense to remove calls to anything related to device trees for 
the x86 platform ?

Regards,

Detlev.



             reply	other threads:[~2023-03-17 21:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 21:29 Detlev Casanova [this message]
2023-03-18 20:20 ` [BUG] Devices of uclass BLK are not listed on x86 Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2448736.vk3iotpzCV@arisu \
    --to=detlev.casanova@collabora.com \
    --cc=ascull@google.com \
    --cc=bmeng.cn@gmail.com \
    --cc=ptosi@google.com \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox