From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5655C74A5B for ; Fri, 17 Mar 2023 21:29:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EC43E85F30; Fri, 17 Mar 2023 22:29:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="jXMzkeXV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9729485F3F; Fri, 17 Mar 2023 22:29:53 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1A2C185DB0 for ; Fri, 17 Mar 2023 22:29:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=detlev.casanova@collabora.com Received: from arisu.localnet (unknown [23.233.251.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id E45A866030B6; Fri, 17 Mar 2023 21:29:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679088589; bh=pk7mVQ43WFdG9Gs7puPJI94r6bBp926ZBh4D1E6x4UE=; h=From:To:Cc:Subject:Date:From; b=jXMzkeXVnIbxMYtKWTUD7jm+Q+wGLaLNrlK/BK+C4rTqYeGA1MQZzFYZw4MR5m4f5 t2ztAKmBhOwXJBxlQxUVp2bHs6N+ixWvKfe2vP87NOmfXIzu42MMo4tU7ehq5LKCfz Vq4WAbYbVvfwcQiFXNTMHiff4AhRcrJuaQLPe7i0vBoIa2fdgibxA8u50GvQYjNK/i MXi6ApvtNWL+XzJG+8MomaYvOsFkvIgtMrUS9WuI3WDduevb6VCwGCIpfRQRni3I00 nYDgWSfLVUpFgHm6RzySY6e1AwhWABywQA8itkaRFfEfg4oAIs3Icad4Yx8hmaLnyG ls8eg9fjbOskA== From: Detlev Casanova To: u-boot@lists.denx.de Cc: Stefan Roese , =?ISO-8859-1?Q?Pierre=2DCl=E9ment?= Tosi , Bin Meng , Andrew Scull Subject: [BUG] Devices of uclass BLK are not listed on x86 Date: Fri, 17 Mar 2023 17:29:48 -0400 Message-ID: <2448736.vk3iotpzCV@arisu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello, We have been having an issue with IDE and SCSI drives not being usable on the x86 architecture. After bisecting, it looks like commit f2ebaaa9f38dddddefaf2e616a9fc489fe8b4021 (pci: Handle failed calloc in decode_regions()) is the culprit. Indeed, it was working when decode_regions() was not returning an error. But now that it does, no blk devices get registered anymore. The decode_regions() function fails because it calls "ofnode_get_property", which fails on systems that do not use a device tree Would it make sense to remove calls to anything related to device trees for the x86 platform ? Regards, Detlev.