From: Fabian Vogt <fvogt@suse.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information
Date: Fri, 09 Apr 2021 15:13:25 +0200 [thread overview]
Message-ID: <2457747.Vy9l6mxcH5@linux-e202.suse.de> (raw)
In-Reply-To: <20210409123511.5827-1-matthias.bgg@kernel.org>
Am Freitag, 9. April 2021, 14:35:10 CEST schrieb matthias.bgg at kernel.org:
> From: Matthias Brugger <mbrugger@suse.com>
>
> At present SMBIOS tables are emtpy,
^ typo
> which breaks some use-cases that rely on that.
Can you give an example?
> Add some minimal information to
Isn't it possible to get the complete information from the firmware here?
That would allow to have the correct product and serial at least.
If that's not possible or too complex, then I suggest to use the proper
strings, e.g. "Raspberry Pi", as those are user visible.
> fullfill this.
^ typo
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>
> arch/arm/dts/bcm283x-u-boot.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> index 68d03627f4..f5235cb083 100644
> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> @@ -6,6 +6,26 @@
> * (C) Copyright 2016 Fabian Vogt <fvogt@suse.com>
> */
>
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> + smbios {
> + system {
> + manufacturer = "raspberrypi";
> + product = "rpi";
> + };
> + baseboard {
> + manufacturer = "raspberrypi";
> + product = "rpi";
> + };
> + chassis {
> + manufacturer = "raspberrypi";
> + product = "rpi";
According to doc/device-tree-bindings/sysinfo/smbios.txt, "chassis"
doesn't have a "product".
Cheers,
Fabian
> + };
> + };
> + };
> +};
> +
> &uart0 {
> skip-init;
> u-boot,dm-pre-reloc;
>
next prev parent reply other threads:[~2021-04-09 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:35 [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information matthias.bgg at kernel.org
2021-04-09 12:35 ` [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver matthias.bgg at kernel.org
2021-04-09 13:13 ` Fabian Vogt
2021-04-09 13:13 ` Fabian Vogt [this message]
2021-04-12 13:33 ` [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2457747.Vy9l6mxcH5@linux-e202.suse.de \
--to=fvogt@suse.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox