U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	Andrew Goodbody <andrew.goodbody@linaro.org>,
	 Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Tom Rini <trini@konsulko.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] usb: cdns3: Do not access memory after free
Date: Sat, 23 Aug 2025 14:21:18 +0200	[thread overview]
Message-ID: <24dab90e-b15a-49d6-acbb-3302ae34ac1a@mailbox.org> (raw)
In-Reply-To: <a6bb77e3-2702-469d-a684-0dce753e78b0@ti.com>

On 8/23/25 4:07 AM, Siddharth Vadapalli wrote:

Hi,

>>>>> I was planning to test this patch but the change being made is only
>>>>> applicable to Controller Versions:
>>>>> 	#define DEV_VER_NXP_V1		0x00024502
>>>>> 	#define DEV_VER_TI_V1		0x00024509
>>>>> and not to:
>>>>> 	#define DEV_VER_V2		0x0002450C
>>>>> 	#define DEV_VER_V3		0x0002450d
>>>>>
>>>>> Since I don't have an SoC and a Board with DEV_VER_TI_V1, I cannot test
>>>>> it. However, the change looks correct to me.
>>>>>
>>>>> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>>> The change does indeed look correct.
>>>>
>>>> Do you know who might still have that board and could test ? (and which
>>>> board/soc is that) ?
>>>
>>> None of the boards that I have worked with have a DEV_VER_TI_V1 version
>>> of the controller. I also tried to use the Linux device-tree to check if
>>> I could identify the SoC/board but I was unable to do so.
>> Do you know which SoC is V2 and V3 ?
> 
> I spent more time on this and found out that J721E SR 1.0 has the
> controller with DEV_VER_TI_V1 version but other revisions of J721E as
> well as all of the following SoCs have DEV_VER_V3 version of the
> controller:
> AM64, AM68, AM69, J7200, J721S2, J722S, J742S2 and J784S4.
> 
> I will try to find an SR 1.0 J721E SoC and test the patch on it and
> share the results here.
This is awesome, thank you !

  reply	other threads:[~2025-08-23 12:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 16:30 [PATCH] usb: cdns3: Do not access memory after free Andrew Goodbody
2025-08-14  3:21 ` Marek Vasut
2025-08-14 10:45   ` Andrew Goodbody
2025-08-19 14:51     ` Marek Vasut
2025-08-21  6:16       ` Siddharth Vadapalli
2025-08-21 20:22         ` Marek Vasut
2025-08-22 14:14           ` Siddharth Vadapalli
2025-08-22 14:55             ` Marek Vasut
2025-08-23  2:07               ` Siddharth Vadapalli
2025-08-23 12:21                 ` Marek Vasut [this message]
2025-08-24  8:02                   ` Siddharth Vadapalli
2025-08-28 15:46                     ` Marek Vasut
2025-08-29  4:22                       ` Siddharth Vadapalli
2025-08-29  8:49                         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24dab90e-b15a-49d6-acbb-3302ae34ac1a@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=andrew.goodbody@linaro.org \
    --cc=mkorpershoek@kernel.org \
    --cc=nm@ti.com \
    --cc=s-vadapalli@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox