From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC2A2C433EF for ; Wed, 15 Jun 2022 13:44:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B401E84464; Wed, 15 Jun 2022 15:44:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tNAIBRuR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C67384474; Wed, 15 Jun 2022 15:44:28 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92DA4843E8 for ; Wed, 15 Jun 2022 15:44:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D49D261B11; Wed, 15 Jun 2022 13:44:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17C11C3411B; Wed, 15 Jun 2022 13:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655300663; bh=NnilJTKYT6je2yjQ58ELDqi41HPTNpBbDhXHQ3HLtJA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tNAIBRuR45dJ8YsYBbIWTiJiQjSHtE4i4qE3k499gZvprmosjTQYXo2um8uI9x6bC EtCqWMzZ2aH+dng+mab0DPtW4Bk78lO/hDFL1pC7ggUGnoXysnpk6ZUjTqmhZDAUzV mkkUfhykwDsNP+0HxOl17ckGsKE2NZuUTWBbQfuhc2bzhF3/L4EMcJ/eqFFyfJKyZd KS7iHHVz6bH1cdcQSnbepUyC1dsA5gjlvyoAjQLPK4AntRA2UaHp9oWW1m/12LOX8c hga/4QVXly2gigBlWwv67oXnNInTUYF0lAYkL2C88WFF84h4BBmg1koMdBMCa7+ufC x8iIEck2BVM+A== Message-ID: <25614b05-be32-9e8f-e576-8fe6210c5973@kernel.org> Date: Wed, 15 Jun 2022 16:44:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RFC v3 08/11] ti: j721e: Exclude makefile tispl.bin target for J721E Content-Language: en-US To: Neha Malcom Francis , trini@konsulko.com, alpernebiyasak@gmail.com, a-govindraju@ti.com, vigneshr@ti.com Cc: u-boot@lists.denx.de, afd@ti.com References: <20220615064804.29553-1-n-francis@ti.com> <20220615064804.29553-9-n-francis@ti.com> From: Roger Quadros In-Reply-To: <20220615064804.29553-9-n-francis@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Neha, On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin is to be packaged (with ATF, OPTEE, DM and A72 SPL) using > binman. The tispl.bin target from the makefile is no longer needed for > J721E. > > Signed-off-by: Neha Malcom Francis > --- > arch/arm/mach-k3/config.mk | 5 +++++ > scripts/Makefile.spl | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk > index d706d17788..dd5e42d9df 100644 > --- a/arch/arm/mach-k3/config.mk > +++ b/arch/arm/mach-k3/config.mk > @@ -74,6 +74,7 @@ ifeq ($(CONFIG_SOC_K3_J721E),) > export DM := /dev/null > endif > > +ifndef CONFIG_TARGET_J721E_A72_EVM How about using #ifndef CONFIG_BINMAN instead? Any platform enabling that doesn't want to use the old way. You are still breaking HS functionality with this series correct? That will have to be fixed. One proposal was discussed here https://lore.kernel.org/all/76474ded-a782-f491-eac6-ece3c5f4a7da@gmail.com/ We should be able to produce tispl.bin_HS and u-boot.img_HS via binman. You have already covered most of the x509 stuff image in ti-x509-cert etype. Please refer to below script [1] to know what is required to get _HS images. [1] https://git.ti.com/cgit/security-development-tools/core-secdev-k3/tree/scripts/secure-binary-image.sh > ifeq ($(CONFIG_TI_SECURE_DEVICE),y) > SPL_ITS := u-boot-spl-k3_HS.its > $(SPL_ITS): export IS_HS=1 > @@ -98,9 +99,11 @@ cmd_k3_mkits = \ > $(SPL_ITS): FORCE > $(call cmd,k3_mkits) > endif > +endif > > else > > +ifndef CONFIG_TARGET_J721E_A72_EVM > ifeq ($(CONFIG_TI_SECURE_DEVICE),y) > INPUTS-y += u-boot.img_HS > else > @@ -108,4 +111,6 @@ INPUTS-y += u-boot.img > endif > endif > > +endif > + You will have to enclose below line in #ifndef CONFIG_BINMAN as well. > include $(srctree)/arch/arm/mach-k3/config_secure.mk > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index f047d4e094..6104cb8587 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -591,6 +591,8 @@ $(obj)/$(SPL_BIN).multidtb.fit.lzo: $(obj)/$(SPL_BIN).multidtb.fit > @lzop -f9 $< > $@ > > ifdef CONFIG_ARCH_K3 > +ifndef CONFIG_TARGET_J721E_A72_EVM Is this still being called in-spite of the changes to config.mk? Please use CONFIG_BINMAN instead of CONFIG_TARGET_J721E_A72_EVM > tispl.bin: $(obj)/u-boot-spl-nodtb.bin $(SHRUNK_ARCH_DTB) $(SPL_ITS) FORCE > $(call if_changed,mkfitimage) > endif > +endif cheers, -roger